Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website_sale_loyalty: ewallet application fix #159356

Closed
wants to merge 2 commits into from

Conversation

anko-odoo
Copy link
Contributor

@anko-odoo anko-odoo commented Mar 26, 2024

Due to 994ee3f commit, ewallet could no
longer be applied.

@robodoo
Copy link
Contributor

robodoo commented Mar 26, 2024

@anko-odoo anko-odoo changed the title DD [FIX] website_sale_loyalty: ewallet application fix Mar 26, 2024
@anko-odoo anko-odoo requested a review from Feyensv March 26, 2024 16:17
Due to 994ee3f commit, ewallet could no
longer be applied.
If Loyalty program was set to be applied on future orders,
details of reward would not be shown to user.
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 26, 2024
@Feyensv Feyensv marked this pull request as ready for review March 28, 2024 10:58
@Feyensv
Copy link
Contributor

Feyensv commented Mar 28, 2024

@robodoo r+ rebase-ff

@robodoo
Copy link
Contributor

robodoo commented Mar 28, 2024

Merge method set to rebase and fast-forward.

robodoo pushed a commit that referenced this pull request Mar 28, 2024
Due to 994ee3f commit, ewallet could no
longer be applied.

Part-of: #159356
robodoo pushed a commit that referenced this pull request Mar 28, 2024
If Loyalty program was set to be applied on future orders,
details of reward would not be shown to user.

closes #159356

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 28, 2024
Due to 994ee3f commit, ewallet could no
longer be applied.

Part-of: #159356
robodoo pushed a commit that referenced this pull request Mar 28, 2024
If Loyalty program was set to be applied on future orders,
details of reward would not be shown to user.

closes #159356

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
@robodoo robodoo closed this Mar 29, 2024
@fw-bot fw-bot deleted the saas-17.2-ewallet-fix-anko branch April 12, 2024 01:46
sbel-odoo added a commit to odoo-dev/odoo that referenced this pull request Apr 18, 2024
Currently if a loyalty program applies on future orders, the description is not shown in the ecommerce website.

Steps to reproduce:
-------------------
* Go to the **Website** App
* Under **ecommerce**, select **Discount & Loyalty**
* Select the **Loyalty Program**
* Go in developer mode
* For `Use points on` select `Future Orders`
* Connect to the website using Marc Demo
* Add any product to the cart -> Proceed to checkout
> observations: The description of the loyalty program reward is not showing. The green box to display it is visible, not the text inside.

Why the fix:
------------
Backport of odoo@c4e9eae (odoo#159356)

opw-3858322
robodoo pushed a commit that referenced this pull request Apr 19, 2024
Currently if a loyalty program applies on future orders, the description is not shown in the ecommerce website.

Steps to reproduce:
-------------------
* Go to the **Website** App
* Under **ecommerce**, select **Discount & Loyalty**
* Select the **Loyalty Program**
* Go in developer mode
* For `Use points on` select `Future Orders`
* Connect to the website using Marc Demo
* Add any product to the cart -> Proceed to checkout
> observations: The description of the loyalty program reward is not showing. The green box to display it is visible, not the text inside.

Why the fix:
------------
Backport of c4e9eae (#159356)

opw-3858322

closes #161935

Signed-off-by: Sarah Bellefroid (sbel) <sbel@odoo.com>
alialfie pushed a commit to odoo-dev/odoo that referenced this pull request Apr 22, 2024
Currently if a loyalty program applies on future orders, the description is not shown in the ecommerce website.

Steps to reproduce:
-------------------
* Go to the **Website** App
* Under **ecommerce**, select **Discount & Loyalty**
* Select the **Loyalty Program**
* Go in developer mode
* For `Use points on` select `Future Orders`
* Connect to the website using Marc Demo
* Add any product to the cart -> Proceed to checkout
> observations: The description of the loyalty program reward is not showing. The green box to display it is visible, not the text inside.

Why the fix:
------------
Backport of odoo@c4e9eae (odoo#159356)

opw-3858322

closes odoo#161935

Signed-off-by: Sarah Bellefroid (sbel) <sbel@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants