Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] mail: opening chat with deleted new message should mark as read #159362

Commits on Mar 26, 2024

  1. [FIX] mail: opening chat with deleted new message should mark as read

    Before this commit, when a user of in chat posted a message and
    deleted it, all other users kept the chat as unread.
    
    Steps to reproduce:
    - Connect as Admin and March Demo
    - Send a message to Admin as Demo in DM chat
    - Demo deletes this message
    - Marc opens the chat
    => the unread counter is 1 and cannot be removed
    
    This happens because when a message is deleted, there's still a
    trace of it but the message is empty. However, empty messages could
    not be candidate of setting the last message being seing by a member,
    thus members were unable to mark the chat as read until someone else
    posted a newer message (and did not delete it).
    
    This commit fixes the issue by taking empty messages into account for
    setting last message message of member, which allow to mark thread as
    read even when newer messages have been deleted.
    
    opw-3764410
    
    X-original-commit: 7c7634e
    alexkuhn committed Mar 26, 2024
    Copy the full SHA
    d233f5b View commit details
    Browse the repository at this point in the history