[FW][FIX] hr_holidays: apply timezone on request date #159380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: ------------------- - be in a UTC+08:00 (or more) timezone - go to Time Off dashboard - click on a day (to request a leave) Issue: ------ Default request dates are on 2 days instead of 1. Cause: ------ Default request dates are determined during an onchange. The datetimes (`default_date_from/to`) are set in the context in UTC calculated in relation to the client's timezone. Consequently, these datetimes can be set over several days. In the backend, we will use these datetimes and take only the day (because the `request_date_from/to` fields are of type date). Solution: --------- Put the values back into the client's timezone before they are truncated. opw-3789265 X-original-commit: a5a860f
|
@thle-odoo @Bertrand2 this PR targets master and is the last of the forward-port chain containing: To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@thle-odoo @Bertrand2 ci/runbot failed on this forward-port PR |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 28, 2024
Steps to reproduce: ------------------- - be in a UTC+08:00 (or more) timezone - go to Time Off dashboard - click on a day (to request a leave) Issue: ------ Default request dates are on 2 days instead of 1. Cause: ------ Default request dates are determined during an onchange. The datetimes (`default_date_from/to`) are set in the context in UTC calculated in relation to the client's timezone. Consequently, these datetimes can be set over several days. In the backend, we will use these datetimes and take only the day (because the `request_date_from/to` fields are of type date). Solution: --------- Put the values back into the client's timezone before they are truncated. opw-3789265 closes #159380 X-original-commit: a5a860f Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com> Signed-off-by: Thomas Lefebvre (thle) <thle@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 28, 2024
Steps to reproduce: ------------------- - be in a UTC+08:00 (or more) timezone - go to Time Off dashboard - click on a day (to request a leave) Issue: ------ Default request dates are on 2 days instead of 1. Cause: ------ Default request dates are determined during an onchange. The datetimes (`default_date_from/to`) are set in the context in UTC calculated in relation to the client's timezone. Consequently, these datetimes can be set over several days. In the backend, we will use these datetimes and take only the day (because the `request_date_from/to` fields are of type date). Solution: --------- Put the values back into the client's timezone before they are truncated. opw-3789265 closes #159380 X-original-commit: a5a860f Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com> Signed-off-by: Thomas Lefebvre (thle) <thle@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 28, 2024
Steps to reproduce: ------------------- - be in a UTC+08:00 (or more) timezone - go to Time Off dashboard - click on a day (to request a leave) Issue: ------ Default request dates are on 2 days instead of 1. Cause: ------ Default request dates are determined during an onchange. The datetimes (`default_date_from/to`) are set in the context in UTC calculated in relation to the client's timezone. Consequently, these datetimes can be set over several days. In the backend, we will use these datetimes and take only the day (because the `request_date_from/to` fields are of type date). Solution: --------- Put the values back into the client's timezone before they are truncated. opw-3789265 closes #159380 X-original-commit: a5a860f Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com> Signed-off-by: Thomas Lefebvre (thle) <thle@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 29, 2024
Steps to reproduce: ------------------- - be in a UTC+08:00 (or more) timezone - go to Time Off dashboard - click on a day (to request a leave) Issue: ------ Default request dates are on 2 days instead of 1. Cause: ------ Default request dates are determined during an onchange. The datetimes (`default_date_from/to`) are set in the context in UTC calculated in relation to the client's timezone. Consequently, these datetimes can be set over several days. In the backend, we will use these datetimes and take only the day (because the `request_date_from/to` fields are of type date). Solution: --------- Put the values back into the client's timezone before they are truncated. opw-3789265 closes #159380 X-original-commit: a5a860f Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com> Signed-off-by: Thomas Lefebvre (thle) <thle@odoo.com>
fw-bot
deleted the
master-17.0-opw-3789265-issue_timezone_time_off-thle-g5n8-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Issue:
Default request dates are on 2 days instead of 1.
Cause:
Default request dates are determined during an onchange. The datetimes (
default_date_from/to) are set in the context in UTC calculated in relation to the client's timezone.Consequently, these datetimes can be set over several days. In the backend, we will use these datetimes and take only the day (because the
request_date_from/tofields are of type date).Solution:
Put the values back into the client's timezone before they are truncated.
opw-3789265
Forward-Port-Of: #159288
Forward-Port-Of: #158042