Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] account: remove newId from display_name for invoices #159400

Closed

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Mar 26, 2024

Steps to reproduce

  • Create a new Invoice

=> The tab title is Odoo - Draft Invoice (* NewId_0x7f545c9d6980)

Cause of the issue

In 17, the display_name is computed for the tab title

return this.model.root.data.display_name || (this.model.root.isNew && _t("New")) || "";

opw-3794671

Forward-Port-Of: #159301

Steps to reproduce
==================

- Create a new Invoice

=> The tab title is `Odoo - Draft Invoice (* NewId_0x7f545c9d6980)`

Cause of the issue
==================

In 17, the display_name is computed for the tab title

https://github.com/odoo/odoo/blob/82fd8e702588d2cc5bdad474ed21188257cc7397/addons/web/static/src/views/form/form_controller.js#L342

opw-3794671

X-original-commit: 80e0f34
@robodoo
Copy link
Contributor

robodoo commented Mar 26, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 26, 2024

@hubvd this PR targets master and is the last of the forward-port chain containing:

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Mar 26, 2024
@robodoo robodoo added the forwardport This PR was created by @fw-bot label Mar 26, 2024
@hubvd
Copy link
Contributor

hubvd commented Mar 27, 2024

@fw-bot r+

robodoo pushed a commit that referenced this pull request Mar 29, 2024
Steps to reproduce
==================

- Create a new Invoice

=> The tab title is `Odoo - Draft Invoice (* NewId_0x7f545c9d6980)`

Cause of the issue
==================

In 17, the display_name is computed for the tab title

https://github.com/odoo/odoo/blob/82fd8e702588d2cc5bdad474ed21188257cc7397/addons/web/static/src/views/form/form_controller.js#L342

opw-3794671

closes #159400

X-original-commit: 80e0f34
Signed-off-by: Hubert Van De Walle <huvw@odoo.com>
@robodoo robodoo closed this Mar 29, 2024
@robodoo robodoo added the 17.3 label Mar 29, 2024
@fw-bot fw-bot deleted the master-17.0-opw-3794671-huvw-WkeV-fw branch April 12, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants