Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: position_hook select iframe content through hoot-dom #159436

Closed

Conversation

bastien-ipb
Copy link
Contributor

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Mar 27, 2024

@C3POdoo C3POdoo requested review from a team, Iucapad and juliusc2066 and removed request for a team March 27, 2024 10:18
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 27, 2024
@bastien-ipb bastien-ipb force-pushed the master-hoot_useposition_hook_fix-ipb branch 2 times, most recently from 53dd890 to 654eab2 Compare March 27, 2024 12:59
Copy link
Contributor

@aab-odoo aab-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

@aab-odoo
Copy link
Contributor

@d-fence fyi

The iframe was not loaded when accessing to her content
even though the await.

Now the test is more like the QUnit version that was
working.

Fixes runbot error 60943
@bastien-ipb bastien-ipb force-pushed the master-hoot_useposition_hook_fix-ipb branch from 654eab2 to 8e4d174 Compare March 28, 2024 10:35
Copy link
Contributor

@aab-odoo aab-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Mar 29, 2024
The iframe was not loaded when accessing to her content
even though the await.

Now the test is more like the QUnit version that was
working.

Fixes runbot error 60943

closes #159436

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
@robodoo robodoo added the 17.3 label Mar 29, 2024
@robodoo robodoo closed this Mar 29, 2024
@fw-bot fw-bot deleted the master-hoot_useposition_hook_fix-ipb branch April 12, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants