Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mail: added a search button for whatsapp channels #159461

Open
wants to merge 1 commit into
base: saas-16.3
Choose a base branch
from

Conversation

akap-odoo
Copy link

Current behavior before PR:

In mobile view, whatsapp tab had no search button.

Desired behavior after PR is merged:

In mobile view, added a search button to find whatsapp channel.

task-id:3525542


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Mar 27, 2024

@C3POdoo C3POdoo added the RD research & development, internal work label Mar 27, 2024
Copy link
Contributor

@rapr-odoo rapr-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks!

@akap-odoo akap-odoo force-pushed the saas-16.3-fix-discuss-whatsapp-channel-search-akap branch from 22ae7a6 to 778ab47 Compare March 29, 2024 05:25
Copy link
Contributor

@rapr-odoo rapr-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. Just some small optimisations.

@akap-odoo akap-odoo force-pushed the saas-16.3-fix-discuss-whatsapp-channel-search-akap branch from 778ab47 to f994cda Compare April 1, 2024 06:21
@akap-odoo
Copy link
Author

Looks OK. Just some small optimisations.

Changed the code according to your suggestions.

@akap-odoo akap-odoo force-pushed the saas-16.3-fix-discuss-whatsapp-channel-search-akap branch 2 times, most recently from 0d542d1 to f905d6f Compare April 1, 2024 08:45
@akap-odoo akap-odoo requested a review from rapr-odoo April 1, 2024 08:46
@akap-odoo akap-odoo force-pushed the saas-16.3-fix-discuss-whatsapp-channel-search-akap branch from f905d6f to 3f7cce2 Compare April 1, 2024 09:35
@seb-odoo seb-odoo marked this pull request as ready for review April 16, 2024 17:08
@C3POdoo C3POdoo requested review from a team April 16, 2024 17:09
Copy link
Contributor

@seb-odoo seb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Ok for the community part, comments in enterprise.

@akap-odoo akap-odoo force-pushed the saas-16.3-fix-discuss-whatsapp-channel-search-akap branch 2 times, most recently from 3cdf81d to 2629371 Compare April 17, 2024 10:42
Before this commit:

In mobile view, whatsapp tab had no search button.

After this commit:

In mobile view, added a search button to find whatsapp channel.

task-id:3525542
@akap-odoo akap-odoo force-pushed the saas-16.3-fix-discuss-whatsapp-channel-search-akap branch from 2629371 to 371b727 Compare April 18, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants