Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][MOV] web, calendar: move common scss into web #159481

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Mar 27, 2024

Move common scss into web

Prior to this PR, some of the main styles related to event elements in calendars were set in the calendar module.
This created layout issues when we installed independent modules without installing calendar (eg. planning or hr_payroll).

To fix that, this PR moves the necessary styles into web and manages duplicated styles in order to remove them.

Adjust hatched events for planning

Prior to this commit, the "hatched" event style in Planning wasn't displayed in Day and Week views.
This commit adjusts the css selector to fix this issue.


task-3617329
Part of task-3575827


Before After
Capture d’écran 2024-02-22 à 08 30 37 Capture d’écran 2024-02-22 à 08 43 32
Capture d’écran 2024-02-22 à 08 31 10 Capture d’écran 2024-02-22 à 08 44 50
Before After
Capture d’écran 2024-03-25 à 11 00 46 Capture d’écran 2024-03-25 à 11 01 06

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #159317
Forward-Port-Of: #154964

Prior to this commit, some of the main styles related to event elements
in calendars were set in the Calendar module.
This created layout issues when we installed independent modules without
installing the Calendar module (eg. `planning` or `hr_payroll`).

To fix that, this commit moves the necessary styles into `web`.

task-3617329
Part of task-3575827

X-original-commit: 5b22e1d
Prior to this commit, the "hatched" event style in Planning wasn't
displayed in Day and Week views.
This commit adjusts the css selector to fix this issue.

task-3617329
Part of task-3575827

X-original-commit: b365592
@robodoo
Copy link
Contributor

robodoo commented Mar 27, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 27, 2024

@Brieuc-brd @pparidans this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Mar 27, 2024
@pparidans
Copy link
Contributor

@fw-bot r+

@C3POdoo C3POdoo added the RD research & development, internal work label Mar 27, 2024
robodoo pushed a commit that referenced this pull request Mar 29, 2024
Prior to this commit, some of the main styles related to event elements
in calendars were set in the Calendar module.
This created layout issues when we installed independent modules without
installing the Calendar module (eg. `planning` or `hr_payroll`).

To fix that, this commit moves the necessary styles into `web`.

task-3617329
Part of task-3575827

X-original-commit: 5b22e1d
Part-of: #159481
robodoo pushed a commit that referenced this pull request Mar 29, 2024
Prior to this commit, the "hatched" event style in Planning wasn't
displayed in Day and Week views.
This commit adjusts the css selector to fix this issue.

task-3617329
Part of task-3575827

closes #159481

X-original-commit: b365592
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 29, 2024
Prior to this commit, some of the main styles related to event elements
in calendars were set in the Calendar module.
This created layout issues when we installed independent modules without
installing the Calendar module (eg. `planning` or `hr_payroll`).

To fix that, this commit moves the necessary styles into `web`.

task-3617329
Part of task-3575827

X-original-commit: 5b22e1d
Part-of: #159481
robodoo pushed a commit that referenced this pull request Mar 29, 2024
Prior to this commit, the "hatched" event style in Planning wasn't
displayed in Day and Week views.
This commit adjusts the css selector to fix this issue.

task-3617329
Part of task-3575827

closes #159481

X-original-commit: b365592
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
@robodoo robodoo closed this Mar 29, 2024
@robodoo robodoo added the 17.3 label Mar 29, 2024
@fw-bot fw-bot deleted the master-17.0-fix-move-calendar-css-to-web-brd-eXhq-fw branch April 12, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants