[FW][FIX] crm: resolve NewId error linking opportunity to contact via studio #159565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue:
- When adding opportunity/lead to a contact using Studio
and attempt to add a line, we encounter the following error:
"TypeError: 'NewId' object is not iterable."
Steps To Reproduce (in 17.0):
- In a contact form open Studio and add a O2M field
Customer (Lead/Opportunity)
- Try to add a line
- Notice Traceback Error "TypeError: 'NewId' object is not iterable"
Solution:
- The issue arises in the search domain of
`return_if_relevant` , exactly in
("partner_id", "child_of", lead.partner_id.commercial_partner_id.id)
where the type of `lead.partner_id.commercial_partner_id.id`
is NewId since the partner is being edited to add a task.
This action triggers the `parse` and `to_ids` methods with
a value type of NewId. thus the error.
- The operator child_of expects a list of IDs, and the ids
property refer to the record's origin ids. to resolve this,
replace `commercial_partner_id.id` with `commercial_partner_id.ids`.
opw-3760372
X-original-commit: 03743a7
|
This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Mar 28, 2024
Issue:
- When adding opportunity/lead to a contact using Studio
and attempt to add a line, we encounter the following error:
"TypeError: 'NewId' object is not iterable."
Steps To Reproduce (in 17.0):
- In a contact form open Studio and add a O2M field
Customer (Lead/Opportunity)
- Try to add a line
- Notice Traceback Error "TypeError: 'NewId' object is not iterable"
Solution:
- The issue arises in the search domain of
`return_if_relevant` , exactly in
("partner_id", "child_of", lead.partner_id.commercial_partner_id.id)
where the type of `lead.partner_id.commercial_partner_id.id`
is NewId since the partner is being edited to add a task.
This action triggers the `parse` and `to_ids` methods with
a value type of NewId. thus the error.
- The operator child_of expects a list of IDs, and the ids
property refer to the record's origin ids. to resolve this,
replace `commercial_partner_id.id` with `commercial_partner_id.ids`.
opw-3760372
closes #159565
X-original-commit: 03743a7
Signed-off-by: Kawtar Drissi El Bouzaidi (kdeb) <kdeb@odoo.com>
fw-bot
deleted the
saas-17.2-17.0-OPW-3760372-crm_child_of_search_error-kdeb-rlce-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Steps To Reproduce:
Solution:
return_if_relevant, exactly in ("partner_id", "child_of", lead.partner_id.commercial_partner_id.id) where the type oflead.partner_id.commercial_partner_id.idis NewId since the partner is being edited to add a task. This action triggers theparseandto_idsmethods with a value type of NewId. thus the error.commercial_partner_id.idwithcommercial_partner_id.ids.opw-3760372
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #159296