New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] website_event_meet, *: properly await edit option before reload #159574
Closed
fw-bot
wants to merge
1
commit into
odoo:master
from
odoo-dev:master-16.0-fix-room-creation-and-more-qsm-6tHh-fw
Closed
[FW][FIX] website_event_meet, *: properly await edit option before reload #159574
fw-bot
wants to merge
1
commit into
odoo:master
from
odoo-dev:master-16.0-fix-room-creation-and-more-qsm-6tHh-fw
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@qsm-odoo this PR targets master and is the last of the forward-port chain containing: To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
*: website_sale This is a follow-up of [1], which missed some occurrence of the same issue that it fixed. E.g. - Add a delay to the "write" of the event model - Go to /event/<event_id>/community - Enter edit mode - Click on the page - Enable the room creation option => The page reloads but nothing seems to have been done... it is actually *being* done: the page reloaded too soon. Note: this commit also marks some other occurrences which are not buggy but might be in the future if not properly changed. To be adapted in the master forward-port. [1]: odoo@556ae45 X-original-commit: fcdd6a8
qsm-odoo
force-pushed
the
master-16.0-fix-room-creation-and-more-qsm-6tHh-fw
branch
from
March 28, 2024 10:29
7dd68a3
to
5dcee64
Compare
qsm-odoo
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
robodoo
pushed a commit
that referenced
this pull request
Mar 30, 2024
*: website_sale This is a follow-up of [1], which missed some occurrence of the same issue that it fixed. E.g. - Add a delay to the "write" of the event model - Go to /event/<event_id>/community - Enter edit mode - Click on the page - Enable the room creation option => The page reloads but nothing seems to have been done... it is actually *being* done: the page reloaded too soon. Note: this commit also marks some other occurrences which are not buggy but might be in the future if not properly changed. To be adapted in the master forward-port. [1]: 556ae45 closes #159574 X-original-commit: fcdd6a8 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 30, 2024
*: website_sale This is a follow-up of [1], which missed some occurrence of the same issue that it fixed. E.g. - Add a delay to the "write" of the event model - Go to /event/<event_id>/community - Enter edit mode - Click on the page - Enable the room creation option => The page reloads but nothing seems to have been done... it is actually *being* done: the page reloaded too soon. Note: this commit also marks some other occurrences which are not buggy but might be in the future if not properly changed. To be adapted in the master forward-port. [1]: 556ae45 closes #159574 X-original-commit: fcdd6a8 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 30, 2024
*: website_sale This is a follow-up of [1], which missed some occurrence of the same issue that it fixed. E.g. - Add a delay to the "write" of the event model - Go to /event/<event_id>/community - Enter edit mode - Click on the page - Enable the room creation option => The page reloads but nothing seems to have been done... it is actually *being* done: the page reloaded too soon. Note: this commit also marks some other occurrences which are not buggy but might be in the future if not properly changed. To be adapted in the master forward-port. [1]: 556ae45 closes #159574 X-original-commit: fcdd6a8 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Mar 31, 2024
*: website_sale This is a follow-up of [1], which missed some occurrence of the same issue that it fixed. E.g. - Add a delay to the "write" of the event model - Go to /event/<event_id>/community - Enter edit mode - Click on the page - Enable the room creation option => The page reloads but nothing seems to have been done... it is actually *being* done: the page reloaded too soon. Note: this commit also marks some other occurrences which are not buggy but might be in the future if not properly changed. To be adapted in the master forward-port. [1]: 556ae45 closes #159574 X-original-commit: fcdd6a8 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*: website_sale
This is a follow-up of 1, which missed some occurrence of the same issue that it fixed.
E.g.
actually being done: the page reloaded too soon.
Note: this commit also marks some other occurrences which are not buggy but might be in the future if not properly changed. To be adapted in the master forward-port.
Forward-Port-Of: #159478
Forward-Port-Of: #159316