Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] website_event_meet, *: properly await edit option before reload #159574

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Mar 27, 2024

*: website_sale

This is a follow-up of 1, which missed some occurrence of the same issue that it fixed.

E.g.

  • Add a delay to the "write" of the event model
  • Go to /event/<event_id>/community
  • Enter edit mode
  • Click on the page
  • Enable the room creation option => The page reloads but nothing seems to have been done... it is
    actually being done: the page reloaded too soon.

Note: this commit also marks some other occurrences which are not buggy but might be in the future if not properly changed. To be adapted in the master forward-port.

Forward-Port-Of: #159478
Forward-Port-Of: #159316

@robodoo
Copy link
Contributor

robodoo commented Mar 27, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 27, 2024

@qsm-odoo this PR targets master and is the last of the forward-port chain containing:

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Mar 27, 2024
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 27, 2024
*: website_sale

This is a follow-up of [1], which missed some occurrence of the same
issue that it fixed.

E.g.
- Add a delay to the "write" of the event model
- Go to /event/<event_id>/community
- Enter edit mode
- Click on the page
- Enable the room creation option
=> The page reloads but nothing seems to have been done... it is
   actually *being* done: the page reloaded too soon.

Note: this commit also marks some other occurrences which are not buggy
but might be in the future if not properly changed. To be adapted in the
master forward-port.

[1]: odoo@556ae45

X-original-commit: fcdd6a8
@qsm-odoo qsm-odoo force-pushed the master-16.0-fix-room-creation-and-more-qsm-6tHh-fw branch from 7dd68a3 to 5dcee64 Compare March 28, 2024 10:29
@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 28, 2024

@qsm-odoo this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo)

Copy link
Contributor

@qsm-odoo qsm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@C3POdoo C3POdoo requested a review from a team March 28, 2024 10:51
robodoo pushed a commit that referenced this pull request Mar 30, 2024
*: website_sale

This is a follow-up of [1], which missed some occurrence of the same
issue that it fixed.

E.g.
- Add a delay to the "write" of the event model
- Go to /event/<event_id>/community
- Enter edit mode
- Click on the page
- Enable the room creation option
=> The page reloads but nothing seems to have been done... it is
   actually *being* done: the page reloaded too soon.

Note: this commit also marks some other occurrences which are not buggy
but might be in the future if not properly changed. To be adapted in the
master forward-port.

[1]: 556ae45

closes #159574

X-original-commit: fcdd6a8
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 30, 2024
*: website_sale

This is a follow-up of [1], which missed some occurrence of the same
issue that it fixed.

E.g.
- Add a delay to the "write" of the event model
- Go to /event/<event_id>/community
- Enter edit mode
- Click on the page
- Enable the room creation option
=> The page reloads but nothing seems to have been done... it is
   actually *being* done: the page reloaded too soon.

Note: this commit also marks some other occurrences which are not buggy
but might be in the future if not properly changed. To be adapted in the
master forward-port.

[1]: 556ae45

closes #159574

X-original-commit: fcdd6a8
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 30, 2024
*: website_sale

This is a follow-up of [1], which missed some occurrence of the same
issue that it fixed.

E.g.
- Add a delay to the "write" of the event model
- Go to /event/<event_id>/community
- Enter edit mode
- Click on the page
- Enable the room creation option
=> The page reloads but nothing seems to have been done... it is
   actually *being* done: the page reloaded too soon.

Note: this commit also marks some other occurrences which are not buggy
but might be in the future if not properly changed. To be adapted in the
master forward-port.

[1]: 556ae45

closes #159574

X-original-commit: fcdd6a8
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
robodoo pushed a commit that referenced this pull request Mar 31, 2024
*: website_sale

This is a follow-up of [1], which missed some occurrence of the same
issue that it fixed.

E.g.
- Add a delay to the "write" of the event model
- Go to /event/<event_id>/community
- Enter edit mode
- Click on the page
- Enable the room creation option
=> The page reloads but nothing seems to have been done... it is
   actually *being* done: the page reloaded too soon.

Note: this commit also marks some other occurrences which are not buggy
but might be in the future if not properly changed. To be adapted in the
master forward-port.

[1]: 556ae45

closes #159574

X-original-commit: fcdd6a8
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo robodoo added the 17.3 label Mar 31, 2024
@robodoo robodoo closed this Mar 31, 2024
@qsm-odoo qsm-odoo deleted the master-16.0-fix-room-creation-and-more-qsm-6tHh-fw branch April 2, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants