[FIX] sale_loyalty_delivery: fix reward for multiple delivery lines #159584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vava-odoo
force-pushed
the
15.0-fix-several-delivery-lines-vava
branch
from
a99b742
to
3a612a5
Compare
vava-odoo
changed the title
vava-odoo
force-pushed
the
15.0-fix-several-delivery-lines-vava
branch
from
3a612a5
to
68c3ebb
Compare
Feyensv
reviewed
Mar 28, 2024
The method `_get_reward_values_free_shipping` assumes there is only one delivery line per sale order. But it is not always the case. This commit therefore makes sure the method does not raise an error in case of multiple lines by taking into account only the first delivery line. Fixes odoo#136395
vava-odoo
force-pushed
the
15.0-fix-several-delivery-lines-vava
branch
from
68c3ebb
to
e41b5c2
Compare
Feyensv
approved these changes
Mar 28, 2024
|
@robodoo r+ |
|
@vava-odoo you may want to rebuild or fix this PR as it has failed CI. |
willylohws
pushed a commit
to willylohws/odoo
that referenced
this pull request
May 1, 2024
The method `_get_reward_values_free_shipping` assumes there is only one delivery line per sale order. But it is not always the case. This commit therefore makes sure the method does not raise an error in case of multiple lines by taking into account only the first delivery line. Fixes odoo#136395 closes odoo#159584 Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
_get_reward_values_free_shippingassumes there is only one delivery line per sale order. But it is not always the case. This commit therefore makes sure the method does not raise an error in case of multiple lines by taking into account only the first delivery line.Fixes #136395