New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW][FIX] Payment: prevent error in rendering payment icon list with PIL incompatible icon image formats #159586
Conversation
@CLaurelB @AntoineVDV cherrypicking of pull request #158728 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Hello @AntoineVDV, since the payment icon image has been replaced by the payment method image in version 17.0, the solution needed to be updated for the forward port. The new approach is in the following PR: #159603 |
…incompatible icon image formats Replace the use of 't-esc' with 't-field' for the payment icon image in the icons list template. The latter, for an image field, provides two options for rendering the payment icon image: use the PIL library to obtain the image when given the option 'qweb_img_raw_data', or use a URL. The former only considers the first option, allowing only image formats compatible with the PIL library. X-original-commit: bc76cca
45221eb
to
78d2c21
Compare
@robodoo r+ |
Hi @CLaurelB, yes indeed. I made the changes in this PR to keep working on the forward-port chain ;) |
Description of the issue/feature this PR addresses:
Replace the use of 't-esc' with 't-field' for the payment icon image in the icons list template. The latter, for an image field, provides two options for rendering the payment icon image: use the PIL library to obtain the image when given the option 'qweb_img_raw_data', or use a URL. The former only considers the first option, allowing only image formats compatible with the PIL library.
Current behavior before PR:
Only image formats compatible with the PIL library can be used for the payment icons.
Desired behavior after PR is merged:
Other formats including the ones compatible with the PIL library can be used for the payment icons.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #159522
Forward-Port-Of: #158728