[FW][FIX] website_sale: Terms and conditions keep button disabled #159587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HANNICHE-Walid @AntoineVDV this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@HANNICHE-Walid @AntoineVDV ci/runbot failed on this forward-port PR |
HANNICHE-Walid
force-pushed
the
master-saas-16.3-opw-3698804-TCPayButton-waha-qpMw-fw
branch
from
1a12fc5
to
003e156
Compare
Steps to reproduce: - Setup sendcloud shipping (shipping product 10-30KG) - Enable demo payment - On the website proceed to checkout (customizable desk) - Select sendcloud (Pay button is disabled) - Edit website and add terms and conditions - Now if you uncheck and recheck terms and conditions - Pay button is enabled although carrier is in error Fix: when reenabling the pay button we check that the carrier is ready but we only check if there's pickup point ensure that the shipping method is avialable before enabling the pay button opw-3698804 X-original-commit: 7682c4b
|
@HANNICHE-Walid @AntoineVDV this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo) |
HANNICHE-Walid
force-pushed
the
master-saas-16.3-opw-3698804-TCPayButton-waha-qpMw-fw
branch
from
003e156
to
4454123
Compare
|
@fw-bot r+ |
|
@HANNICHE-Walid I can only do this on unmodified forward-port PRs, ask robodoo. |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 30, 2024
Steps to reproduce: - Setup sendcloud shipping (shipping product 10-30KG) - Enable demo payment - On the website proceed to checkout (customizable desk) - Select sendcloud (Pay button is disabled) - Edit website and add terms and conditions - Now if you uncheck and recheck terms and conditions - Pay button is enabled although carrier is in error Fix: when reenabling the pay button we check that the carrier is ready but we only check if there's pickup point ensure that the shipping method is avialable before enabling the pay button opw-3698804 closes #159587 X-original-commit: 7682c4b Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com> Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>
fw-bot
deleted the
master-saas-16.3-opw-3698804-TCPayButton-waha-qpMw-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Fix:
when reenabling the pay button we check that the
carrier is ready but we only check if there's pickup point ensure that the shipping method is avialable before enabling the pay button
opw-3698804
Forward-Port-Of: #159133