Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] sale: forbid pricelist changes on confirmed orders #159694

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Mar 28, 2024

It cannot happen through the default SO form view, but some funny guys have found other ways to do it, even though it can be quite problematic, especially if the new pricelist is in another currency.


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #157742

@robodoo
Copy link
Contributor

robodoo commented Mar 28, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 28, 2024

This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Mar 28, 2024
@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 28, 2024

@Feyensv ci/style failed on this forward-port PR

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 28, 2024

@Feyensv ci/runbot failed on this forward-port PR

It cannot happen through the default SO form view, but some funny guys
have found other ways to do it, even though it can be quite problematic,
especially if the new pricelist is in another currency.

X-original-commit: dc7b75f
@Feyensv Feyensv force-pushed the saas-17.1-17.0-sale-pricelist-changes-on-confirmed-order-vfe-XQBU-fw branch from 1e7f42d to f03c90a Compare March 28, 2024 14:59
@Feyensv
Copy link
Contributor

Feyensv commented Mar 28, 2024

@robodoo r+

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 28, 2024

@Feyensv this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo)

@C3POdoo C3POdoo added the RD research & development, internal work label Mar 28, 2024
robodoo pushed a commit that referenced this pull request Mar 28, 2024
It cannot happen through the default SO form view, but some funny guys
have found other ways to do it, even though it can be quite problematic,
especially if the new pricelist is in another currency.

closes #159694

X-original-commit: dc7b75f
Related: odoo/enterprise#59658
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
@robodoo robodoo closed this Mar 28, 2024
@fw-bot fw-bot deleted the saas-17.1-17.0-sale-pricelist-changes-on-confirmed-order-vfe-XQBU-fw branch April 11, 2024 23:47
alialfie pushed a commit to odoo-dev/odoo that referenced this pull request Apr 22, 2024
It cannot happen through the default SO form view, but some funny guys
have found other ways to do it, even though it can be quite problematic,
especially if the new pricelist is in another currency.

closes odoo#159694

X-original-commit: dc7b75f
Related: odoo/enterprise#59658
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants