Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] Payment: prevent error in rendering payment icon list with PIL incompatible icon image formats #159697

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 6 additions & 8 deletions addons/payment/views/payment_form_templates.xml
Expand Up @@ -228,8 +228,7 @@
</div>
<!-- === Payment method logo === -->
<div t-call="payment.form_logo">
<t t-set="logo" t-value="token_sudo.payment_method_id.image_payment_form"/>
<t t-set="title" t-value="token_sudo.payment_method_id.name"/>
<t t-set="logo_pm_sudo" t-value="token_sudo.payment_method_id"/>
</div>
</div>
<!-- === Inline form === -->
Expand Down Expand Up @@ -309,8 +308,7 @@
<t t-set="pm_index" t-value="0"/>
<t t-foreach="pms_to_display_sudo" t-as="pm_to_display_sudo">
<t t-if="pm_index &lt; 4" t-call="payment.form_logo">
<t t-set="logo" t-value="pm_to_display_sudo.image_payment_form"/>
<t t-set="title" t-value="pm_to_display_sudo.name"/>
<t t-set="logo_pm_sudo" t-value="pm_to_display_sudo"/>
</t>
<t t-set="pm_index" t-value="pm_index + 1"/>
</t>
Expand Down Expand Up @@ -383,13 +381,13 @@

<template id="payment.form_logo" name="Form Logo">
<!-- Parameters description:
- logo: The logo to display, as an `Image` field.
- title: The title to display on hover.
- logo_pm_sudo: The payment method whose logo to display, as a sudoed `payment.method`
record.
-->
<span t-out="logo"
<span t-field="logo_pm_sudo.image_payment_form"
t-options="{'widget': 'image', 'alt-field': 'name'}"
class="position-relative d-block rounded overflow-hidden z-index-1 shadow-sm"
t-att-title="title"
t-att-title="logo_pm_sudo.name"
data-bs-toggle="tooltip"
data-bs-placement="top"
data-bs-delay="0"
Expand Down