Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] point_of_sale: show the loading PoS data error #159710

Closed
wants to merge 1 commit into from
Closed

[FIX] point_of_sale: show the loading PoS data error #159710

wants to merge 1 commit into from

Conversation

pedrambiria
Copy link
Contributor

@pedrambiria pedrambiria commented Mar 28, 2024 •
edited

Before this commit, if there was an error, the PoS stays on
the loading page which was confusing for the user.

owp-3834647

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Mar 28, 2024 •
edited

Pull request status dashboard.

@C3POdoo C3POdoo added the RD research & development, internal work label Mar 28, 2024
@C3POdoo C3POdoo requested review from a team and adgu-odoo and removed request for a team March 28, 2024 15:15
@caburj @pedrambiria
[FIX] point_of_sale: show the loading PoS data error
30130d7 
Before this commit, if there was an error, the PoS stays on
the loading page which was confusing for the user.

owp-3834647
@pedrambiria pedrambiria changed the title wip [FIX] point_of_sale: show the loading PoS data error Mar 28, 2024
adgu-odoo
adgu-odoo approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@adgu-odoo adgu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for me. Can you ping rd-security to get an override ?

@pedrambiria
Copy link
Contributor Author

@odoo/rd-security could you please override the security?

@mart-e
Copy link
Contributor

mart-e commented Mar 29, 2024

@robodoo override=ci/security
Reason: static url

@adgu-odoo
Copy link
Contributor

@robodoo r+

@robodoo robodoo closed this in 6418638 Apr 2, 2024
@fw-bot fw-bot mentioned this pull request Apr 2, 2024
Closed
@fw-bot
Copy link
Contributor

fw-bot commented Apr 6, 2024

@pedrambiria @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

6 similar comments
@fw-bot
Copy link
Contributor

fw-bot commented Apr 7, 2024

@pedrambiria @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Contributor

fw-bot commented Apr 8, 2024

@pedrambiria @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Contributor

fw-bot commented Apr 9, 2024

@pedrambiria @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Contributor

fw-bot commented Apr 10, 2024

@pedrambiria @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Contributor

fw-bot commented Apr 11, 2024

@pedrambiria @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Contributor

fw-bot commented Apr 12, 2024

@pedrambiria @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot fw-bot mentioned this pull request Apr 12, 2024
Closed
@fw-bot
Copy link
Contributor

fw-bot commented Apr 14, 2024

@pedrambiria @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot fw-bot deleted the 17.0-fix-pos-3834647-pebr branch April 16, 2024 10:46
@fw-bot fw-bot mentioned this pull request Apr 18, 2024
Closed
@fw-bot
Copy link
Contributor

fw-bot commented Apr 22, 2024

@pedrambiria @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

willylohws pushed a commit to willylohws/odoo that referenced this pull request May 1, 2024
@caburj @willylohws
[FIX] point_of_sale: show the loading PoS data error
550ce4a 
Before this commit, if there was an error, the PoS stays on
the loading page which was confusing for the user.

owp-3834647

closes odoo#159710

Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
@fw-bot
Copy link
Contributor

fw-bot commented May 8, 2024

@pedrambiria @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adgu-odoo adgu-odoo adgu-odoo approved these changes

Assignees
No one assigned
Labels
RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pedrambiria @robodoo @mart-e @adgu-odoo @fw-bot @C3POdoo @caburj