[FW][FIX] website_sale: harmonize tax computation #159764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Feyensv @smetl cherrypicking of pull request #159122 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
Feyensv
force-pushed
the
saas-16.3-16.0-wsale-tax-broll-vfe-u9UY-fw
branch
3 times, most recently
from
3a9737d
to
f4bdbf2
Compare
separate the true computation of the tax value from the computation of the base unit price (uom & curr conversion, ...). That way, the risks of unwanted side-effects is reduced when the base unit price is already computed (sale, website_sale). Also allows preprocessing the taxes mapping, which doesn't have to be done multiple times when we compute different amounts for the same product/template. original commit: 9ba0bf8
Feyensv
force-pushed
the
saas-16.3-16.0-wsale-tax-broll-vfe-u9UY-fw
branch
5 times, most recently
from
4bbce71
to
8400616
Compare
Standard `sale` tax flows rely on `_get_tax_included_price_unit`, whereas part of `website_sale` flows do, while another part relies on `_fix_tax_included_price_company`, which doesn't handle some advanced cases (fiscal position mapping of price_included taxes). This commit drops the use of `_fix_tax_included_price_company` in website_sale, to only use the newest API of `_get_tax_included_price_unit`, supposed to handle more cases. Also makes all taxes computation go through a single entry point, `_apply_taxes_to_price`, already used for `combination_info` logic (/shop/product), but not in `_get_sales_prices` (/shop page). opw-3700803 original commit : 5e522d4
Feyensv
force-pushed
the
saas-16.3-16.0-wsale-tax-broll-vfe-u9UY-fw
branch
from
8400616
to
cc9c014
Compare
|
@robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Apr 2, 2024
separate the true computation of the tax value from the computation of the base unit price (uom & curr conversion, ...). That way, the risks of unwanted side-effects is reduced when the base unit price is already computed (sale, website_sale). Also allows preprocessing the taxes mapping, which doesn't have to be done multiple times when we compute different amounts for the same product/template. original commit: 9ba0bf8 Part-of: #159764
robodoo
pushed a commit
that referenced
this pull request
Apr 2, 2024
Standard `sale` tax flows rely on `_get_tax_included_price_unit`, whereas part of `website_sale` flows do, while another part relies on `_fix_tax_included_price_company`, which doesn't handle some advanced cases (fiscal position mapping of price_included taxes). This commit drops the use of `_fix_tax_included_price_company` in website_sale, to only use the newest API of `_get_tax_included_price_unit`, supposed to handle more cases. Also makes all taxes computation go through a single entry point, `_apply_taxes_to_price`, already used for `combination_info` logic (/shop/product), but not in `_get_sales_prices` (/shop page). opw-3700803 original commit : 5e522d4 closes #159764 Signed-off-by: Laurent Smet (las) <las@odoo.com> Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard
saletax flows rely on_get_tax_included_price_unit,whereas part of
website_saleflows do, while another part relieson
_fix_tax_included_price_company, which doesn't handle someadvanced cases (fiscal position mapping of price_included taxes).
This commit drops the use of
_fix_tax_included_price_companyinwebsite_sale, to only use the newest API of
_get_tax_included_price_unit,supposed to handle more cases.
Also makes all taxes computation go through a single entry point,
_apply_taxes_to_price, already used forcombination_infologic (/shop/product),but not in
_get_sales_prices(/shop page).opw-3700803
Fixes #155162
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #159122