[FIX] setup.nsi: prevent installation of nginx in a user folder #160054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit: If a windows iot odoo installation is made on a user folder (like Desktop), nginx will not be able to start with the following error: `[emerg] 8144#3304: CreateFile() "C:\Users\...\nginx-1.22.0/conf/nginx.conf" failed (5: Access is denied)` On which the only solution that we found was to give access to the user folder to the "LocalService" user. After this commit: As it is not a feasable solution, we will prevent Odoo's install in a user folder to avoid this issue opw-3827086
lse-odoo
force-pushed
the
16.0-windows_installer_prevent_user_folder_nginx-lse
branch
from
bb5bc7b
to
f4b57ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit:
If a windows iot odoo installation is made on a user folder (like Desktop), nginx will not be able to start with the following error:
[emerg] 8144#3304: CreateFile() "C:\Users\...\nginx-1.22.0/conf/nginx.conf" failed (5: Access is denied)On which the only solution that we found was to give access to the user folder to the "LocalService" user.After this commit:
As it is not a feasible solution, we will prevent Odoo's install in a user folder to avoid this issue
opw-3827086