[IMP] web: Always show the name of the company on the app top right #160057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hsal-odoo
force-pushed
the
master-web-show_company_name-hsal
branch
from
9925fba
to
baacdbb
Compare
C3POdoo
requested review from
a team,
aab-odoo and
Iucapad
and removed request for
a team
hsal-odoo
force-pushed
the
master-web-show_company_name-hsal
branch
from
baacdbb
to
31575da
Compare
malb-odoo
approved these changes
Apr 19, 2024
|
yeah, I think @Olivier-olma simply missed it. Well seen @malb-odoo . I propose to replace the company selector with just a label if len(companies) == 1 |
|
You are right, I missed it, thanks @malb-odoo |
hsal-odoo
force-pushed
the
master-web-show_company_name-hsal
branch
from
31575da
to
8e35859
Compare
|
@qdp-odoo should be fixed now |
malb-odoo
reviewed
May 29, 2024
addons/web/static/src/webclient/switch_company_menu/switch_company_menu.js
Outdated
Show resolved
Hide resolved
hsal-odoo
force-pushed
the
master-web-show_company_name-hsal
branch
2 times, most recently
from
c542201
to
f84e57f
Compare
malb-odoo
approved these changes
May 29, 2024
aab-odoo
reviewed
May 30, 2024
hsal-odoo
force-pushed
the
master-web-show_company_name-hsal
branch
2 times, most recently
from
4695d88
to
cce9d50
Compare
|
@aab-odoo @malb-odoo I have added a unit test |
aab-odoo
reviewed
May 31, 2024
hsal-odoo
force-pushed
the
master-web-show_company_name-hsal
branch
2 times, most recently
from
72437df
to
9ca7d9c
Compare
|
LGTM as well! |
|
@BastienFafchamps you may want to rebuild or fix this PR as it has failed CI. |
hsal-odoo
force-pushed
the
master-web-show_company_name-hsal
branch
3 times, most recently
from
9f9399c
to
99c8c8f
Compare
Removed the isDisplayed condition of the SwitchCompanyMenu component. With this, the name of the company on the top right of the app will always be shown even is there is only one company. Also, if there is a single company, the company selector will be disabled. The name of the company on the top right of the app was hidden when there was only one company. task-3829645
hsal-odoo
force-pushed
the
master-web-show_company_name-hsal
branch
from
99c8c8f
to
8adaa1b
Compare
|
@BastienFafchamps Please review my last update. I have only added nullish coalescing operator for |
|
@robodoo r+ @hsal-odoo thanks! |
robodoo
pushed a commit
that referenced
this pull request
Jun 7, 2024
Removed the isDisplayed condition of the SwitchCompanyMenu component. With this, the name of the company on the top right of the app will always be shown even is there is only one company. Also, if there is a single company, the company selector will be disabled. The name of the company on the top right of the app was hidden when there was only one company. task-3829645 closes #160057 Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the isDisplayed condition of the SwitchCompanyMenu component.
With this, the name of the company on the top right of the app will always be shown even is there is only one company.
Also, if there is a single company, the company selector will be disabled.
The name of the company on the top right of the app was hidden when there was only one company.
task-3829645
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr