[IMP] web_editor: use esc to discard transform on image #160071
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adch-odoo
force-pushed
the
17.0-discard-transform-on-esc-adch
branch
from
b57c04c
to
82916cd
Compare
deso-odoo
reviewed
Apr 15, 2024
adch-odoo
force-pushed
the
17.0-discard-transform-on-esc-adch
branch
3 times, most recently
from
e1a0003
to
fe892a8
Compare
adch-odoo
force-pushed
the
17.0-discard-transform-on-esc-adch
branch
3 times, most recently
from
9236de6
to
1a6db6b
Compare
|
Runbot seems to be red for this PR. You may want to rebase and force push the branch. |
Purpose of this commit: This commit implements a functionality where pressing the 'Escape' key removes the transform widget from the image. task-3839151
Purpose of this commit: This commit ensures that pressing any character key does not result in the removal of the image when the transform widget is active. task-3839151
deso-odoo
force-pushed
the
17.0-discard-transform-on-esc-adch
branch
from
1a6db6b
to
4cec5b9
Compare
|
@dmo-odoo Rebased the branch, runbot is green 🟢 |
|
@robodoo rebase-ff r+ |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
May 21, 2024
Purpose of this commit: This commit implements a functionality where pressing the 'Escape' key removes the transform widget from the image. task-3839151 Part-of: #160071
robodoo
pushed a commit
that referenced
this pull request
May 21, 2024
Purpose of this commit: This commit ensures that pressing any character key does not result in the removal of the image when the transform widget is active. task-3839151 closes #160071 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 21, 2024
Purpose of this commit: This commit implements a functionality where pressing the 'Escape' key removes the transform widget from the image. task-3839151 Part-of: #160071
robodoo
pushed a commit
that referenced
this pull request
May 21, 2024
Purpose of this commit: This commit ensures that pressing any character key does not result in the removal of the image when the transform widget is active. task-3839151 closes #160071 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 21, 2024
Purpose of this commit: This commit implements a functionality where pressing the 'Escape' key removes the transform widget from the image. task-3839151 Part-of: #160071
robodoo
pushed a commit
that referenced
this pull request
May 21, 2024
Purpose of this commit: This commit ensures that pressing any character key does not result in the removal of the image when the transform widget is active. task-3839151 closes #160071 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 21, 2024
Purpose of this commit: This commit implements a functionality where pressing the 'Escape' key removes the transform widget from the image. task-3839151 Part-of: #160071
robodoo
pushed a commit
that referenced
this pull request
May 21, 2024
Purpose of this commit: This commit ensures that pressing any character key does not result in the removal of the image when the transform widget is active. task-3839151 closes #160071 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
|
@adch-odoo @dmo-odoo staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/build/62803602) |
|
@robodoo retry |
|
I'm sorry, @deso-odoo. I'm afraid I can't do that. |
|
@robodoo retry |
robodoo
pushed a commit
that referenced
this pull request
May 23, 2024
Purpose of this commit: This commit implements a functionality where pressing the 'Escape' key removes the transform widget from the image. task-3839151 Part-of: #160071
This was referenced May 23, 2024
|
@adch-odoo @dmo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
1 similar comment
|
@adch-odoo @dmo-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
lohwswilson
pushed a commit
to lohwswilson/odoo
that referenced
this pull request
Jun 5, 2024
Purpose of this commit: This commit implements a functionality where pressing the 'Escape' key removes the transform widget from the image. task-3839151 Part-of: odoo#160071
lohwswilson
pushed a commit
to lohwswilson/odoo
that referenced
this pull request
Jun 5, 2024
Purpose of this commit: This commit ensures that pressing any character key does not result in the removal of the image when the transform widget is active. task-3839151 closes odoo#160071 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired behavior after PR is merged:
I. This PR implements a functionality where pressing the
Escapekeyremoves the transform widget from the image.
II. Also it ensures that pressing any character key does not result in the
removal of the image when the transform widget is active.
task-3839151