[FIX] web_editor: upload CORS images by URL

[AH-Yussef]

Steps to reproduce:

• Install E-commerce app
• Go to Website > Shop, and open a product
• Click on edit on the upper right corner.
• Double click the product image to change it. A popup is shown.
• In the popup, click on Add URL and place this URL 1
• Click Save. The image disappears!

Investigation:

• The issue was introduced here 2
• As URL now starts with /web/image/ which will be later used here 3
• The condition to enter this line is url_object.path.startswith('/web/image')
• item[field] is used which equals to attachment[datas]
• But actually datas is empty as the image upload fails because of CORS
• add_url is called 4 saving attachment without datas but with type URL

Fix

• The commit solves the issue by fetching the remote data from the server if the url is a remote redirection, which still happens when the image data cannot be fetched by the client browser at upload time.

opw-3746245

[robodoo]

Pull request status dashboard.

[bso-odoo]

The fix looks ok to fallback to the old behavior. 👍
But I was wondering if it would not make sense to detect the scenario upon attachment upload and do this fetch from server only at that time - instead of at every read access ? @rdeodoo

[rdeodoo]

Indeed.. I think we did not do that because we did not want the server to contact another random server that any of our client can ask us to.
But this load_local_url is already doing it so.. We should definitely fetch the b64 from there at save if we can't do that through the client side.

About the steps to reproduce, note that the image you provided doesn't work on my side (it doesn't let me go through the media dialog). I still reproduced it using any other cors protected image tho.

@robodoo delegate=@bso-odoo

[bso-odoo]

The fix looks ok to fallback to the old behavior. 👍 But I was wondering if it would not make sense to detect the scenario upon attachment upload and do this fetch from server only at that time - instead of at every read access ?

After re-testing, I notice I misunderstood this during my first review. This is actually happening during record save - therefore at upload, which is good news.

[bso-odoo]

@robodoo r+