Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] account: constrict activities summaries within containing card #160167

Conversation

mizosoft
Copy link
Contributor

@mizosoft mizosoft commented Apr 2, 2024

Issue

The activities summaries displayed by the misc. operations view in the accounting
app take up the entire screen and span across the card if the activity summary
is too long.

Steps

  • Open the Accounting App.
  • Create a new entry from 'Miscellaneous Operations'.
  • Add an activity with a long summary.
  • Go back the dashboard. The summary will try to span the entire width.

Cause

The activities are displayed with a field tag in the kanban view. The field tag
refers to the activities js component as a widget. Due the use of a widget attribute,
the template generates a div with class: "o_field_widget". This class is defined
to have a css "display" attribe with a default value of "inline-block". Using "inline-block"
causes the activity row to take up the whole width.

opw-3839992

@robodoo
Copy link
Contributor

robodoo commented Apr 2, 2024

Pull request status dashboard.

@mizosoft mizosoft marked this pull request as draft April 2, 2024 13:42
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Apr 2, 2024
@mizosoft mizosoft force-pushed the 16.0-opw-3839992_dashboard_activities_out_of_frame-mohu branch 4 times, most recently from f013171 to 7940f82 Compare April 3, 2024 12:04
@mizosoft mizosoft changed the title [FIX] account: fix activities alignment in misc. journal view [FIX] account: properly align activities summary in accounting dashboard Apr 3, 2024
@mizosoft mizosoft force-pushed the 16.0-opw-3839992_dashboard_activities_out_of_frame-mohu branch 6 times, most recently from b81bc22 to 6eeaa9d Compare April 10, 2024 10:00
@mizosoft mizosoft changed the title [FIX] account: properly align activities summary in accounting dashboard [FIX] account: constrict activities summaries within containing card Apr 10, 2024
Copy link
Contributor

@nle-odoo nle-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@mizosoft mizosoft force-pushed the 16.0-opw-3839992_dashboard_activities_out_of_frame-mohu branch from 6eeaa9d to 25501ff Compare April 11, 2024 10:59
@mizosoft mizosoft marked this pull request as ready for review April 12, 2024 09:18
@C3POdoo C3POdoo requested review from a team and h4818 and removed request for a team April 12, 2024 09:19
@mizosoft
Copy link
Contributor Author

Any blocker here?

Copy link
Contributor

@h4818 h4818 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mizosoft
I don't think the comment is necessary either

Issue
-----

The activities summaries displayed by the misc. operations  view in the accounting
app take up the entire screen and span across the card if the activity summary
is too long.

Steps
-----

 - Open the Accounting App.
 - Create a new entry from 'Miscellaneous Operations'.
 - Add an activity with a long summary.
 - Go back the dashboard. The summary will try to span the entire width.

Cause
-----

The activities are displayed with a field tag in the kanban view. The field tag
refers to the activities js component as a widget. Due the use of a widget attribute,
the template generates a div with class: "o_field_widget". This class is defined
to have a css "display" attribe with a default value of "inline-block". Using "inline-block"
causes the activity row to take up the whole width.

opw-3839992
@mizosoft mizosoft force-pushed the 16.0-opw-3839992_dashboard_activities_out_of_frame-mohu branch from 25501ff to 7627ba0 Compare April 18, 2024 15:17
@h4818
Copy link
Contributor

h4818 commented Apr 18, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 18, 2024
Issue
-----

The activities summaries displayed by the misc. operations  view in the accounting
app take up the entire screen and span across the card if the activity summary
is too long.

Steps
-----

 - Open the Accounting App.
 - Create a new entry from 'Miscellaneous Operations'.
 - Add an activity with a long summary.
 - Go back the dashboard. The summary will try to span the entire width.

Cause
-----

The activities are displayed with a field tag in the kanban view. The field tag
refers to the activities js component as a widget. Due the use of a widget attribute,
the template generates a div with class: "o_field_widget". This class is defined
to have a css "display" attribe with a default value of "inline-block". Using "inline-block"
causes the activity row to take up the whole width.

opw-3839992

closes #160167

Signed-off-by: Habib Ayob (ayh) <ayh@odoo.com>
@robodoo robodoo closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants