Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] l10_fr_fec : init line with zero balance should be not include #160767

Closed

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 5, 2024

Description of the issue/feature this PR addresses:
Before this PR initial balance include line with a null balance. In database with lot of partner (e-commerce), the initial balance balance are huge.

  • Create e-commerce
  • Sale and invoice to 100 000 different customer in 2023, all invoice are paid
  • In 2024 extract a FEC
    --> Issue : in the initial balance there are 100 000 lines with a zero balance. This lines don't need to be included in the FEC.

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #160639
Forward-Port-Of: #141321

The FEC report contains initial balances. These representing balances on accounts from the previous period.
When calculating the initial balances, there is no requirement to include balances from the previous period for an account if they are at zero.
When there are settled transactions for many thousands of partners from the previous period, this results in many thousands of initial balance lines in the FEC report that all have a balance of zero.

This PR remove initial line with zero balance.

X-original-commit: 1d1beaf
@robodoo
Copy link
Contributor

robodoo commented Apr 5, 2024

Pull request status dashboard.

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 5, 2024

This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Apr 5, 2024
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 5, 2024
@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 5, 2024

@fmdl @FlorianGilbert the next pull request (#160793) is in conflict. You can merge the chain up to here by saying

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Copy link
Contributor

@FlorianGilbert FlorianGilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fw-bot r+

robodoo pushed a commit that referenced this pull request Apr 22, 2024
The FEC report contains initial balances. These representing balances on accounts from the previous period.
When calculating the initial balances, there is no requirement to include balances from the previous period for an account if they are at zero.
When there are settled transactions for many thousands of partners from the previous period, this results in many thousands of initial balance lines in the FEC report that all have a balance of zero.

This PR remove initial line with zero balance.

closes #160767

X-original-commit: 1d1beaf
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
@robodoo robodoo closed this Apr 22, 2024
@fw-bot fw-bot deleted the saas-17.1-fix-fec-init-oYn8-fw branch May 6, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants