[FW][FIX] purchase_stock: use correct picking when updating purchase qty #161700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the fix, the picking used to create the new stock moves resulting from changes in the purchased quantity is simply taking the first available picking of the Purchase. This causes problems when you handle Purchase Orders with multiple open pickings, as the correct picking to use when the quantity is updated is not always taken. After the fix we give priority to evaluate open pickings already related to the line we are updating. We fallback to the same behaviour as before is none is available. X-original-commit: b333556
|
|
|
This PR targets saas-16.4 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
This was referenced Apr 12, 2024
robodoo
pushed a commit
that referenced
this pull request
Apr 22, 2024
Before the fix, the picking used to create the new stock moves resulting from changes in the purchased quantity is simply taking the first available picking of the Purchase. This causes problems when you handle Purchase Orders with multiple open pickings, as the correct picking to use when the quantity is updated is not always taken. After the fix we give priority to evaluate open pickings already related to the line we are updating. We fallback to the same behaviour as before is none is available. closes #161700 X-original-commit: b333556 Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
fw-bot
deleted the
saas-16.4-16.0-fix-purchase_stock-update_purchase_qty-DFWT-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
In systems were POs can have multiple open pickings, updating the Purchase quantities can lead to errors due to the current behaviour.
Current behavior before PR:
Before the fix, the picking used to create the new stock moves resulting from changes in the purchased quantity is simply taking the first available picking of the Purchase. This causes problems when you handle Purchase Orders with multiple open pickings, as the correct picking to use when the quantity is updated is not always taken.
Desired behavior after PR is merged:
After the fix we give priority to evaluate open pickings already related to the line we are updating. We fallback to the same behaviour as before is none is available.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #161452