[FIX] website_sale_loyalty: Fix coupon deletion #161817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
red runbot seems maybe related to the scope, can you take a look? |
mathysPaul
force-pushed
the
16.0-website_sale-error-remove-promo-from-cart-matp
branch
4 times, most recently
from
78c3f13
to
1d4a293
Compare
Resolves a problem when removing a coupon from an order containing different tax applications. If an order is composed of products with varying tax rates, the coupon applied generates separate lines for each unique tax situation. This includes non-taxed products, products with individual taxes, and combinations thereof. The purpose of this commit is to fix the management of coupon deletion in cases where the coupon generates multiple lines for different tax scenarios. Adjusting the recovery process to select the first coupon line identifier, ensuring that the correct line is targeted for deletion in scenarios with multiple tax-related coupon lines. Example: - Product A (non-taxed) - Product B (Tax A) - Product C (Tax B) - Product D (Tax A and B) The coupon would generate four separate lines for non-taxed, Tax A, Tax B, and Tax A & B scenarios, respectively. opw-3693319
Feyensv
force-pushed
the
16.0-website_sale-error-remove-promo-from-cart-matp
branch
from
1d4a293
to
77b2af3
Compare
robodoo
pushed a commit
that referenced
this pull request
Apr 25, 2024
Resolves a problem when removing a coupon from an order containing different tax applications. If an order is composed of products with varying tax rates, the coupon applied generates separate lines for each unique tax situation. This includes non-taxed products, products with individual taxes, and combinations thereof. The purpose of this commit is to fix the management of coupon deletion in cases where the coupon generates multiple lines for different tax scenarios. Adjusting the recovery process to select the first coupon line identifier, ensuring that the correct line is targeted for deletion in scenarios with multiple tax-related coupon lines. Example: - Product A (non-taxed) - Product B (Tax A) - Product C (Tax B) - Product D (Tax A and B) The coupon would generate four separate lines for non-taxed, Tax A, Tax B, and Tax A & B scenarios, respectively. opw-3693319 closes #161817 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
This was referenced Apr 25, 2024
|
@mathysPaul @Feyensv this pull request has forward-port PRs awaiting action (not merged or closed): |
MohammedBasioni
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 29, 2024
Resolves a problem when removing a coupon from an order containing different tax applications. If an order is composed of products with varying tax rates, the coupon applied generates separate lines for each unique tax situation. This includes non-taxed products, products with individual taxes, and combinations thereof. The purpose of this commit is to fix the management of coupon deletion in cases where the coupon generates multiple lines for different tax scenarios. Adjusting the recovery process to select the first coupon line identifier, ensuring that the correct line is targeted for deletion in scenarios with multiple tax-related coupon lines. Example: - Product A (non-taxed) - Product B (Tax A) - Product C (Tax B) - Product D (Tax A and B) The coupon would generate four separate lines for non-taxed, Tax A, Tax B, and Tax A & B scenarios, respectively. opw-3693319 closes odoo#161817 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
|
@mathysPaul @Feyensv this pull request has forward-port PRs awaiting action (not merged or closed): |
2 similar comments
|
@mathysPaul @Feyensv this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@mathysPaul @Feyensv this pull request has forward-port PRs awaiting action (not merged or closed): |
This was referenced May 2, 2024
|
@mathysPaul @Feyensv this pull request has forward-port PRs awaiting action (not merged or closed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a problem when removing a coupon from an order containing different tax applications.
If an order is composed of products with varying tax rates, the coupon applied generates separate lines for each unique tax situation. This includes non-taxed products, products with individual taxes, and combinations thereof.
The purpose of this commit is to fix the management of coupon deletion in cases where the coupon generates multiple lines for different tax scenarios. Adjusting the recovery process to select the first coupon line identifier, ensuring that the correct line is targeted for deletion in scenarios with multiple tax-related coupon lines.
Example:
The coupon would generate four separate lines for non-taxed, Tax A, Tax B, and Tax A & B scenarios, respectively.
opw-3693319