Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] google_calendar: fix duplicate first event issue in google calendar #161835

Draft
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

nikj-odoo
Copy link
Contributor

Version:

16.0

Steps to Reproduce:

  • Install the calendar and Google Calendar.
  • Sync with Google Calendar.
  • Create an all-day event with recurrence.

Issue:

  • The first event gets duplicated when created as an "All-day" event with recurrence.

Cause:

  • The duplication occurs because when creating an all-day event with recurrence, two events are generated daily. However, during editing, one event may be mistakenly converted to a non-recurring event, resulting in apparent duplication.

Solution:

  • To fix this, the google_insert method has been adjusted to insert an additional event in Google Calendar only when a recurrence condition is met, thereby preventing the duplication of the first event.

task-3768121


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Apr 15, 2024

@C3POdoo C3POdoo added the RD research & development, internal work label Apr 15, 2024
@nikj-odoo nikj-odoo force-pushed the 16.0-fix-recurrent-first-event-duplicate-nikj branch 2 times, most recently from 377a78c to 8981472 Compare April 19, 2024 13:03
…ndar

Steps to Reproduce:
- Install the calendar and Google Calendar.
- Sync with Google Calendar.
- Create an all-day event with recurrence.

Issue:
- The first event gets duplicated when created as an "All-day" event with
  recurrence.

Cause:
- The duplication occurs because when creating an all-day event with recurrence,
  two events are generated daily. However, during editing, one event may be
  mistakenly converted to a non-recurring event, resulting in apparent
  duplication.

Solution:
- To fix this, the google_insert method has been adjusted to insert an
  additional event in Google Calendar only when a recurrence condition is met,
  thereby preventing the duplication of the first event.

task-3768121
@nikj-odoo nikj-odoo force-pushed the 16.0-fix-recurrent-first-event-duplicate-nikj branch from 8981472 to c9cd9c1 Compare April 24, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants