[IMP] test_lint: add lint tests for translations #161842
Draft
+105
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the following checks for translation antipatterns: + Usage of `_, `_lt` function with multiple unnamed placeholders + Concatenation of translated text + Usage of `_t` function with multiple unnamed placeholders + Concatenation of translated text + .js files: + Backslash-newline in translated strings + .xml files: + Translated attributes as props + Human-readable text in Qweb directives + Call to _t in Owl templates Task-3869533
odony
reviewed
Apr 15, 2024
Comment on lines
+33
to
+39
| { | ||
| "selector": "CallExpression[callee.name='_t'] > :first-child[value=/(.*%s){2,}/]", | ||
| "message": "Usage of _t function with multiple unnamed placeholders" | ||
| }, | ||
| { | ||
| "selector": "BinaryExpression[operator='+'] > CallExpression[callee.name='_t']", | ||
| "message": "Concatenation of translated text" |
There was a problem hiding this comment.
it would be nice to separate the rules and give them meaningful names like no-translations-concat and no-translation-unnamed-placeholders, rather than putting them under no-restricted-syntax. This way they can be selectively disabled, e.g with /* eslint-disable no-translations-concat */ or /* eslint-disable-next-line no-translations-concat */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following checks for translation antipatterns:
Pylint
_,_lt` function with multiple unnamed placeholdersESLint
_tfunction with multiple unnamed placeholdersPython tests
_t in Owl templatesTask-3869533