[FIX] mrp: delivery slip kit packaging different Uoms components #161920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HANNICHE-Walid
force-pushed
the
17.0-opw-3758203-kitPdeliverySlip-waha
branch
3 times, most recently
from
80d5dca
to
001252d
Compare
Whenrow
reviewed
May 3, 2024
Whenrow
reviewed
May 3, 2024
Whenrow
reviewed
May 3, 2024
Whenrow
reviewed
May 3, 2024
Whenrow
reviewed
May 3, 2024
Steps to reproduce: - Create a kit with components Uom set as Kg - Create an SO for the kit using packaging - Validate the delivery and try printing the delivery slip ERROR Bug: when generating the delivery slip we convert movelines qty to the packaging Uom but in the case of a kit the movelines are those of the components (in this we're converting Kg to units) Fix: Ignore kit lines (will be removed any way in _get_aggregated_product_quantities) opw-3758203
HANNICHE-Walid
force-pushed
the
17.0-opw-3758203-kitPdeliverySlip-waha
branch
from
001252d
to
47da1ec
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 24, 2024
Steps to reproduce: - Create a kit with components Uom set as Kg - Create an SO for the kit using packaging - Validate the delivery and try printing the delivery slip ERROR Bug: when generating the delivery slip we convert movelines qty to the packaging Uom but in the case of a kit the movelines are those of the components (in this we're converting Kg to units) Fix: Ignore kit lines (will be removed any way in _get_aggregated_product_quantities) opw-3758203 closes #161920 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 24, 2024
Steps to reproduce: - Create a kit with components Uom set as Kg - Create an SO for the kit using packaging - Validate the delivery and try printing the delivery slip ERROR Bug: when generating the delivery slip we convert movelines qty to the packaging Uom but in the case of a kit the movelines are those of the components (in this we're converting Kg to units) Fix: Ignore kit lines (will be removed any way in _get_aggregated_product_quantities) opw-3758203 closes #161920 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
|
@HANNICHE-Walid @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed): |
This was referenced May 28, 2024
|
@HANNICHE-Walid @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed): |
2 similar comments
|
@HANNICHE-Walid @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@HANNICHE-Walid @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@HANNICHE-Walid @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@HANNICHE-Walid @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed): |
2 similar comments
|
@HANNICHE-Walid @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@HANNICHE-Walid @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed): |
lohwswilson
pushed a commit
to lohwswilson/odoo
that referenced
this pull request
Jun 5, 2024
Steps to reproduce: - Create a kit with components Uom set as Kg - Create an SO for the kit using packaging - Validate the delivery and try printing the delivery slip ERROR Bug: when generating the delivery slip we convert movelines qty to the packaging Uom but in the case of a kit the movelines are those of the components (in this we're converting Kg to units) Fix: Ignore kit lines (will be removed any way in _get_aggregated_product_quantities) opw-3758203 closes odoo#161920 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Bug:
when generating the delivery slip we convert movelines qty to the packaging Uom but in the case of a kit the movelines are those of the components (in this we're converting Kg to units)
Fix:
Ignore kit lines (will be removed any way in _get_aggregated_product_quantities)
opw-3758203