[FIX] pos_self_order_sale: check if the field really exists #161921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| @@ -9,5 +9,9 @@ class ProductProduct(models.Model): | |||
| def _get_product_for_ui(self, pos_config): | |||
| self.ensure_one() | |||
| product = super()._get_product_for_ui(pos_config) | |||
|
|
|||
| if "optional_product_ids" not in self.env["product.product"]: | |||
There was a problem hiding this comment.
could be better but I'm not sure
product_configurator = self.env['ir.module.module']._get('sale_product_configurator')
if product_configurator.state != 'installed':
return product
``
nle-odoo
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
looks good to me if there is no better way
the clean way to do this would be to have a bridge between pos_self_order and sale_product_configurator and do this override in that bridge but it would mean adding a new module (that I think needs an exception and so on)
the other nearly clean way would be to:
- add a method
_get_product_for_uireturning eg. empty dict inpoint_of_sale - transfer this override to
pos_sale_product_configurator - modify the method in
pos_self_orderso it calls the new method from point_of_sale and extend the dictionary
but maybe it's too many changes not worth the hustle.
When the module "sale_product_configurator" is not installed, an AttributeError is raised Steps to reproduce: Install the "point_of_sale" app, the "pos_self_order_sale" module and remove the "sale_product_configurator" module Go to settings -> point of sale -> Self ordering: QR Menu -> preview web interface Cause: The field "optional_product_ids" is provided by the module "sale_product_configurator" which is not a dependency of this module opw-3850421
Axel927
force-pushed
the
17.0-opw-3850421-pos_menu_no_attribute-axtr
branch
from
dce8b99
to
a1d697c
Compare
This was referenced Apr 23, 2024
willylohws
pushed a commit
to willylohws/odoo
that referenced
this pull request
May 1, 2024
When the module "sale_product_configurator" is not installed, an AttributeError is raised Steps to reproduce: Install the "point_of_sale" app, the "pos_self_order_sale" module and remove the "sale_product_configurator" module Go to settings -> point of sale -> Self ordering: QR Menu -> preview web interface Cause: The field "optional_product_ids" is provided by the module "sale_product_configurator" which is not a dependency of this module opw-3850421 closes odoo#161921 Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the module "sale_product_configurator" is not installed, an AttributeError is raised
Steps to reproduce:
Cause:
The field "optional_product_ids" is provided by the module "sale_product_configurator" which is not a dependency of this module
opw-3850421
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr