15.0 fix stock warehouse orderpoint unlink domain #161925
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
C3POdoo
added
CLA
|
Hi and thank you for contributing! Could you please add a test to your PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Fulfilling the if condition doesn't change anything as the the result of the concatenation isn't attributed. Also the domain contains an error as it should be id and not ids.
Current behavior before PR:
If record(s) are passed through the super, it doesn't change anything to the method's behavior as the domain stays the same.
Desired behavior after PR is merged:
If self.ids is true, the new value of domain would be: domain + [('id', 'in', self.ids]]).
@pgu-odoo
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr