Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] payment_mercado_pago: fix checkout process #161977

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

ALopez-Adhoc
Copy link

Description of the issue/feature this PR addresses:
'sandbox_init_point' is deprecated. Although it still exists in the payment preference creation, it is no longer functional in the result; 'init_point' should always be used instead. In the case of test credentials, 'init_point' will always behave as if in a test environment.

Steps to Reproduce:

  • Install the payment_mercado_pago module.
  • Configure the account with the following mercado_pago_access_token: TEST-4811719641145832-020115-c5caffc149634e3e9d72fde2b74544d8__LD_LA__-172837665
  • Initiate a payment process with a published mercado_pago payment provider link.
    The following error occurs:

m_p_error

Removing the 'sandbox' word from the URL generates the payment process correctly.
image (1)
image (2)

Current behavior before PR:
Payment cannot be made in sandbox mode using payment credentials with the mercado_pago provider.

Desired behavior after PR is merged:
The payment process should be completed successfully using test credentials for the mercado_pago provider.


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Apr 15, 2024

@C3POdoo C3POdoo requested a review from a team April 15, 2024 18:17
@C3POdoo C3POdoo added the Payment Payment providers label Apr 15, 2024
@lathama
Copy link
Contributor

lathama commented Apr 15, 2024

@ALopez-Adhoc I think the git commit msg needs a space after [FIX] but I don't see it mentioned at https://www.odoo.com/documentation/17.0/contributing/development/git_guidelines.html#tag-and-module-name but also possible it does not like the :

@ALopez-Adhoc ALopez-Adhoc changed the title [FIX]payment_mercado_pago:fix checkout process [FIX] payment_mercado_pago: fix checkout process Apr 16, 2024
@ALopez-Adhoc
Copy link
Author

@lathama Hi Andrew! Thank you for the feedback. I reviewed the documentation and made the corresponding changes. I did not remove the ':' since it appeared after the module name, but I added spaces after the tag and the ':'.

@lathama
Copy link
Contributor

lathama commented Apr 16, 2024

Awesome sauce! I was sleepy when commenting, the : was a mistake on my part.

@lathama
Copy link
Contributor

lathama commented Apr 16, 2024

@vava-odoo can you connect a code owner to review this?

@vava-odoo
Copy link
Contributor

@lathama Unlike issues, PRs are automatically assiged to the responsible team. In this case, the one about online payments was pinged and will answer as soon as they can.

Copy link
Contributor

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ALopez-Adhoc, do you have a link to a statement from MercadoPago about deprecating the sandbox_init_point key?

I've tested the payment page while keeping the sandbox. subdomain with your API key and it worked fine. The official documentation of the Checkout API also doesn't mention deprecating that response key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Payment Payment providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants