Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] point_of_sale: simplify list view #162010

Closed

Conversation

sjai-odoo
Copy link

@sjai-odoo sjai-odoo commented Apr 16, 2024

Before this commit

Closing date and balance fields were already displayed in the kanban view,
but were missing from the list view, causing inconsistency between the two views.

After this commit

Now the closing date and balance fields are added to the list view of the
pos_config.

task- 3647820

@robodoo
Copy link
Contributor

robodoo commented Apr 16, 2024

@C3POdoo C3POdoo added the RD research & development, internal work label Apr 16, 2024
Comment on lines 114 to 115
<field name="currency_id" column_invisible="True"/>
<field name="last_session_closing_cash" string="Balance" widget="monetary"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<field name="currency_id" column_invisible="True"/>
<field name="last_session_closing_cash" string="Balance" widget="monetary"/>
<field name="currency_id" column_invisible="True"/>
<field name="last_session_closing_cash" widget="monetary" string="Balance"/>

@sjai-odoo sjai-odoo force-pushed the master-pos-simplify-list-view-sjai branch from 6565c1c to 2042004 Compare April 24, 2024 06:22
@ppr-odoo
Copy link
Contributor

@sjai-odoo
Commit and PR titles are not per our guidelines. link

cc @paso-odoo

Before this commit:
Closing date and balance fields were already displayed in the kanban view,
but were missing from the list view, causing inconsistency between the two views.

After this commit:
Now the closing date and balance fields are added to the list view of the
pos_config.

task- 3647820
@sjai-odoo sjai-odoo force-pushed the master-pos-simplify-list-view-sjai branch from 2042004 to fb2a82c Compare April 24, 2024 08:33
@sjai-odoo sjai-odoo changed the title [ADD] point_of_sale: simplify List view [IMP] point_of_sale: simplify list view Apr 24, 2024
@sjai-odoo sjai-odoo marked this pull request as ready for review May 20, 2024 07:25
@C3POdoo C3POdoo requested review from a team and adgu-odoo and removed request for a team May 20, 2024 07:27
@adgu-odoo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request May 21, 2024
Before this commit:
Closing date and balance fields were already displayed in the kanban view,
but were missing from the list view, causing inconsistency between the two views.

After this commit:
Now the closing date and balance fields are added to the list view of the
pos_config.

task- 3647820

closes #162010

Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
@robodoo robodoo closed this May 21, 2024
@robodoo robodoo added the 17.3 label May 21, 2024
Megaaaaaa pushed a commit to odoo-dev/odoo that referenced this pull request May 21, 2024
Before this commit:
Closing date and balance fields were already displayed in the kanban view,
but were missing from the list view, causing inconsistency between the two views.

After this commit:
Now the closing date and balance fields are added to the list view of the
pos_config.

task- 3647820

closes odoo#162010

Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
zel-odoo pushed a commit to odoo-dev/odoo that referenced this pull request May 24, 2024
Before this commit:
Closing date and balance fields were already displayed in the kanban view,
but were missing from the list view, causing inconsistency between the two views.

After this commit:
Now the closing date and balance fields are added to the list view of the
pos_config.

task- 3647820

closes odoo#162010

Signed-off-by: Adrien Guilliams (adgu) <adgu@odoo.com>
@fw-bot fw-bot deleted the master-pos-simplify-list-view-sjai branch June 4, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants