[IMP] *: gantt: variable range and horizontal virtualization #162017
+132
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polymorphe57
force-pushed
the
master-gantt-v3-dam
branch
5 times, most recently
from
6f72755
to
86bd373
Compare
Polymorphe57
commented
Apr 25, 2024
Polymorphe57
force-pushed
the
master-gantt-v3-dam
branch
12 times, most recently
from
0f5caaf
to
f79a321
Compare
Polymorphe57
force-pushed
the
master-gantt-v3-dam
branch
4 times, most recently
from
da7877a
to
b489ba5
Compare
Polymorphe57
force-pushed
the
master-gantt-v3-dam
branch
5 times, most recently
from
7846899
to
3ede548
Compare
Polymorphe57
force-pushed
the
master-gantt-v3-dam
branch
from
3ede548
to
cf8e143
Compare
|
@robodoo rebase-ff |
|
I'm sorry, @Polymorphe57: you can't method=rebase-ff. |
Polymorphe57
force-pushed
the
master-gantt-v3-dam
branch
2 times, most recently
from
da09b66
to
13d9039
Compare
Polymorphe57
changed the title
This commit allows to prevent the next eventual click event which could happen on drag end if the user does a pointer up above the initially dragged element. It is useful to prevent any click handler from triggering after a drag sequence was initiated so that the handlers don't overlap with each others in this special case.
This commit changes the way the draggable hooks handle the "edge scrolling": - before this commit: scrolling started when the dragged element approached a border of one of its scrollable parents; - now: scrolling starts when the cursor approaches a border of the scrollable parent.
We make possible to block the edge scrolling in one direction when dragging. This can be achieved by setting a new option "direction" in the param edgeScrolling of the draggable hook builder. That option can take two values: "horizontal" or "vertical". If edgeScrolling is enabled and that option is set, scroll will only be possible in that direction.
After this commit, the edge scrolling case will continuously call the onDrag handler. This is useful when a visual feedback is computed in the caller's onDrag handler. This is now a requirement for the v3 gantt view. Task: 3601456
After this commit, the caller's side will know in the dragging context which edge is being scrolled (on edge scrolling situations obviously).
A new param "inBounds" is introduced for getPickerCell. If set to true, only the values in the current selected datepicker range are returned.
This commit slightly changes the signature of the `makePopover` utility function in order to ease its override. Before it expected the whole popover service API, only to use its `add` function. Now it expects directly the add function. Another change is also introduced: the DateTimePicker hook and the datetimepicker service now give an easy access to the `createPopover` function (which is essentially the `makePopover` utility function). These changes will allow the v3 gantt view (task 3601456) to place its date pickers in dialogs when the display is small.
This commit force the datetime_picker's cells to have the same aspect ratio without any specific width or height on small screen. So the datetime_picker can take the all width space available and be always responsive as each cells share the same width and the same height to respect the aspect ratio.
This commit adds a custom class for stacking two elements
as in some case the `fa-stack` class doesn't work correctly.
This new class align the inner item on the base line instead
of being centered.
e.g. of usage:
```html
<span class="o_fa_stack">
<i class="fa fa-calendar-o" role="img" aria-label="Today" title="Today"/>
<span>26</span>
</span>
```
By construction, delta is less than threshold in all calls to diffToScroll, so we can simplify a bit the code and remove the call to clamp.
Click on the zoom out button in the datepicker provokes a rendering of the datepicker. So we make the helper zoomOut wait for an animation frame to make it more useful.
Polymorphe57
force-pushed
the
master-gantt-v3-dam
branch
from
13d9039
to
b82266d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.