Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sale_project: add sale_line_div name #162024

Closed

Conversation

desh-odoo
Copy link
Contributor

@desh-odoo desh-odoo commented Apr 16, 2024

this div name is used in fsm sale module

task-3784066

@robodoo
Copy link
Contributor

robodoo commented Apr 16, 2024

@C3POdoo C3POdoo added the RD research & development, internal work label Apr 16, 2024
@ppr-odoo ppr-odoo force-pushed the master-industry_fsm-imp-mobile-view-desh branch 3 times, most recently from 27e8554 to 4c23b35 Compare April 18, 2024 05:11
@ppr-odoo ppr-odoo changed the title [IMP] sale_project: provide name to sale_line_id field div [IMP] sale_project: add sale_line_div name Apr 18, 2024
@desh-odoo desh-odoo force-pushed the master-industry_fsm-imp-mobile-view-desh branch from 4c23b35 to cfd5d93 Compare May 3, 2024 10:21
Copy link
Contributor

@pkyriakou pkyriakou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @desh-odoo 💯 LGTM 🟢 💯

@desh-odoo desh-odoo force-pushed the master-industry_fsm-imp-mobile-view-desh branch 3 times, most recently from df483a0 to 2f45817 Compare May 17, 2024 13:34
@ppr-odoo ppr-odoo force-pushed the master-industry_fsm-imp-mobile-view-desh branch 7 times, most recently from b648c4e to 8e785ad Compare May 23, 2024 14:06
@xavierbol xavierbol force-pushed the master-industry_fsm-imp-mobile-view-desh branch from 8e785ad to 6920a8e Compare May 27, 2024 11:21
@xavierbol xavierbol marked this pull request as ready for review May 28, 2024 07:54
@C3POdoo C3POdoo requested a review from a team May 28, 2024 07:56
desh-odoo and others added 2 commits May 28, 2024 11:18
this div name is used in fsm sale module

task-3784066
This commit allows to add all warnings displayed in the form view of
project.task in one place. It will also allow us to hide all warnings in
a specific view if needed.

task-3784066
@xavierbol xavierbol force-pushed the master-industry_fsm-imp-mobile-view-desh branch from 6920a8e to 465370e Compare May 28, 2024 09:19
@xavierbol
Copy link
Contributor

robodoo rebase-ff r+

@robodoo
Copy link
Contributor

robodoo commented May 28, 2024

Merge method set to rebase and fast-forward.

@robodoo
Copy link
Contributor

robodoo commented May 28, 2024

@desh-odoo @xavierbol linked pull request(s) odoo/enterprise#59506 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request May 28, 2024
this div name is used in fsm sale module

task-3784066

Part-of: #162024
robodoo pushed a commit that referenced this pull request May 28, 2024
This commit allows to add all warnings displayed in the form view of
project.task in one place. It will also allow us to hide all warnings in
a specific view if needed.

task-3784066

closes #162024

Related: odoo/enterprise#59506
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
robodoo pushed a commit that referenced this pull request May 28, 2024
this div name is used in fsm sale module

task-3784066

Part-of: #162024
robodoo pushed a commit that referenced this pull request May 28, 2024
This commit allows to add all warnings displayed in the form view of
project.task in one place. It will also allow us to hide all warnings in
a specific view if needed.

task-3784066

closes #162024

Related: odoo/enterprise#59506
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
@robodoo robodoo added the 17.3 label May 28, 2024
@robodoo robodoo closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants