[FIX] account: ensure non empty VALUES in query

[aj-fuentes]

When the companies of system user are all archived we get an invalid SQL syntax on the output of _from. For normal users having their company_id archived is not a standard flow, but system user (Odoo Bot) is an archived user, thus it can be associated to an archived company (usually the id=1 one).

The invalid query is necessary during the installation of some modules. This operation runs as system user.

Steps reproduce:

1. On a clean DB with just account installed, add an extra company.
2. Archive company 1 (after switching admin/demo/portal to comp2)
3. Set allowed companies of system user to just company 1
4. Try to install gamification_sale_crm

The validation of the domain in for gamification records fail due to the invalid query.

Compare:

>>> self.env['res.currency']._get_query_currency_table(self.env.companies.ids, fields.Date.today())
'(VALUES ) AS currency_table(company_id, rate, precision)'
>>> self.env['res.currency']._get_query_currency_table((self.env.companies | self.env.company).ids, fields.Date.today())
'(VALUES (1, 1.0, 2)) AS currency_table(company_id, rate, precision)'

Setting:

>>> self.env.user
res.users(1,)
>>> self.env.company
res.company(1,)
>>> self.env.company.active
False
>>> self.env.user.with_context(active_test=False).company_ids
res.company(1,)
>>> self.env.companies
res.company()

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

---

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[robodoo]

Pull request status dashboard.

[aj-fuentes]

Hi @svfu-odoo and @william-andre I'm not sure if you'd prefer to handle this issue also in env['res.currency']._get_query_currency_table directly. Maybe raising an error if company_ids is empty, or:

if not company_ids:
   return '(VALUES (NULL::int, NULL::float, NULL::int)) AS currency_table(company_id, rate, precision)'

related to b06da79

[william-andre]

@rco-odoo Is it expected that self.env.company can not be in self.env.companies?

[aj-fuentes]

I updated the PR description with:

>>> self.env.companies
res.company()

It's easily reproducible locally. It looks like self.env.companies only holds active companies. No idea if that's expected or not.

[Feyensv]

@rco-odoo Is it expected that self.env.company can not be in self.env.companies?

Seems to have been introduced by #102586, maybe to confirm with DLE 👀

[KangOl]

//cc @beledouxdenis @rco-odoo