[FIX] base: do not overwrite context when upgrading #162089
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just allow to pass flags to the context of _process_end method. It's better to extend than to force.
C3POdoo
requested review from
a team,
xmo-odoo and
HydrionBurst
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just allow to pass flags to the context of _process_end method. It's better always to extend than to force, as it helps in customizing projects. If you kill contexts, less tools we have at our disposal to do custom things.
And just by coherence, let's harmonize it. Why randomly force or extend? Let's extend by default always.
Already discussed in #71802, but lacked definitive answer.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr