[FIX] point_of_sale : get the order_number from the same sequence as SO #162119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoba-odoo
force-pushed
the
17.0-opw-3809595-pos_order_number-yoba
branch
2 times, most recently
from
6b9b1c7
to
c68302c
Compare
yoba-odoo
force-pushed
the
17.0-opw-3809595-pos_order_number-yoba
branch
12 times, most recently
from
4932316
to
08029de
Compare
yoba-odoo
force-pushed
the
17.0-opw-3809595-pos_order_number-yoba
branch
2 times, most recently
from
c567f8f
to
98c781a
Compare
Steps to reproduce: 1- Install POS and POS restaurant 2- Activate self ordering 3- Create a self order from the mobile menu 4- Create another order from the Shop POS Current behavior before PR: There is a conflict happening in order numbers between Self order and other orders where at some point we might have two orders with the same number. This is happening because when adding the order from Shop we get the sequence number from the JS side in Order class https://github.com/odoo/odoo/blob/d82ffde0b316c52f726c247bf6f3d38e2e73e405/addons/point_of_sale/static/src/app/store/models.js#L1383 but in case of self order. We get it from ir_sequence https://github.com/odoo/odoo/blob/d82ffde0b316c52f726c247bf6f3d38e2e73e405/addons/pos_self_order/controllers/orders.py#L19 So we don't have a shared sequence between them. Desired behavior after PR is merged: We are now getting the sequence number from ir_sequence in both scenarios by fetching the ir_sequence module data when setup the Order JS class. Also, handled so many corner cases to adapt the base change Also changed a check in EWalletProgramTour2 because there is a slight change in the behavior. Before when you go back to the PoS dashboard and click on Continue Selling and enter the PoS session again it will start counting the sequence number from the start again this is not the case right now where we continue on the same sequence until the session gets closed opw-3809595
yoba-odoo
force-pushed
the
17.0-opw-3809595-pos_order_number-yoba
branch
from
98c781a
to
a6191c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
1- Install POS and POS restaurant
2- Activate self ordering
3- Create a self order from the mobile menu
4- Create another order from the Shop POS
Current behavior before PR:
There is a conflict happening in order numbers between Self order and other orders where at some point we might have two orders with the same number. This is happening because when adding the order from Shop we get the sequence number from the JS side in Order class
odoo/addons/point_of_sale/static/src/app/store/models.js
Line 1383 in d82ffde
odoo/addons/pos_self_order/controllers/orders.py
Line 19 in d82ffde
Desired behavior after PR is merged:
We are now getting the sequence number from ir_sequence in both scenarios by fetching the ir_sequence module data when setup the Order JS class.
opw-3809595
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr