[IMP] services: avoid exporting labels of technical fields #162167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MissingNoShiny
force-pushed
the
master-services-technical-fields-vila
branch
from
dda2cbb
to
5f0b068
Compare
MissingNoShiny
changed the title
MissingNoShiny
force-pushed
the
master-services-technical-fields-vila
branch
from
5f0b068
to
3370678
Compare
xavierbol
reviewed
Apr 17, 2024
| @@ -54,19 +54,19 @@ def _domain_employee_id(self): | |||
| 'project.task', 'Task', index='btree_not_null', | |||
| compute='_compute_task_id', store=True, readonly=False, | |||
| domain="[('allow_timesheets', '=', True), ('project_id', '=?', project_id)]") | |||
| parent_task_id = fields.Many2one('project.task', related='task_id.parent_id', store=True) | |||
| parent_task_id = fields.Many2one('project.task', related='task_id.parent_id', store=True, export_string_translation=False) | |||
There was a problem hiding this comment.
This field seems used in the search view, so I guess we should still keep the string translated in that case, right? 🧐
| @@ -10,7 +10,7 @@ class Project(models.Model): | |||
|
|
|||
| allow_timesheets = fields.Boolean( | |||
| "Timesheets", compute='_compute_allow_timesheets', store=True, readonly=False, | |||
| default=True) | |||
| default=True, export_string_translation=False) | |||
There was a problem hiding this comment.
This field seems display in the UI and so I don't think it is a good idea to not translate its string.
What do you think? 🧐
MissingNoShiny
force-pushed
the
master-services-technical-fields-vila
branch
from
3370678
to
a8e3ef7
Compare
xavierbol
approved these changes
Apr 29, 2024
|
@MissingNoShiny @xavierbol unable to stage: merge conflict |
xavierbol
force-pushed
the
master-services-technical-fields-vila
branch
from
a8e3ef7
to
9ff900b
Compare
|
robodoo r+ |
xavierbol
force-pushed
the
master-services-technical-fields-vila
branch
from
9ff900b
to
1698997
Compare
xavierbol
force-pushed
the
master-services-technical-fields-vila
branch
from
1698997
to
bdf813e
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 8, 2024
Task-3631801 closes #162167 Related: odoo/enterprise#60904 Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task-3631801