[IMP] web_editor: improve history dialog UX #162171
Open
+197
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sebgeelen
force-pushed
the
master-history-ux-sge
branch
from
3920ff3
to
073d488
Compare
sebgeelen
force-pushed
the
master-history-ux-sge
branch
2 times, most recently
from
aeda156
to
2c0ee14
Compare
Currently, the history dialog has a shared scroll view for the list of revisions and the diff view. When one of the columns has more content than the other, the shorter column becomes invisible when scrolling down the view, which can be annoying. Example: When there are a lot of revisions and the user picks one at the bottom of the scroll view, the user has to scroll back to the top to read the diff of that revision. To improve the usability of the history dialog, we will ensure that the two columns have their own scroll view. People will then be able to scroll independently in the revision list and the diff view. This commit will also remove the statement blocking the user interface and creating a flicker. task-3853374
When the user loads a new revision, owl will patch the dom and update the content of the diff view but will not reset the scroll offset of the container which can be annoying when clicking from one revision to another. This commit will fix simply fix that issue. task-3853374
* Add some contextual information on history dialog content and comparison. * Improve the revision list by merging changes from the same day toguether and adding the possibility to select a specific revision after selecting the day. * Change call-To-action label to add clarity. * Inverse comparison POV to be more logical. task-3560677
sebgeelen
force-pushed
the
master-history-ux-sge
branch
from
2c0ee14
to
9441d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Scroll behavior between content view and history revision list
Add some contextual information on history dialog content
and comparison.
Improve the revision list by merging changes from the same
day toguether and adding the possibility to select a specific
revision after selecting the day.
Change call-To-action label to add clarity.
Inverse comparison POV to be more logical.
task-3560677
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr