Add filterby in account portal pagination #162172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimaElisabeta
force-pushed
the
16.0-fix_account_portal_pagination
branch
2 times, most recently
from
1320b47
to
0663a08
Compare
C3POdoo
requested review from
a team and
RicGR98
and removed request for
a team
RicGR98
reviewed
Apr 19, 2024
There was a problem hiding this comment.
Thanks for your contribution ! :)
The fix looks good to me. However, could you:
- split the PR into two commits: one for the CLA, the other for the fix
- fix the commit title (for instance the module is missing, please check our guidelines here https://www.odoo.com/documentation/master/contributing/development/git_guidelines.html#tag-and-module-name)
- describe the bug with more details in the commit message (i.e. the filter is not updated when navigating through the pages when we have > 80 records)
SimaElisabeta
force-pushed
the
16.0-fix_account_portal_pagination
branch
from
0663a08
to
5ca7202
Compare
… used when you have invoices pagination, meaning that when you try to navigate to a different page, the filter is not used anymore and showing all invoices.
SimaElisabeta
force-pushed
the
16.0-fix_account_portal_pagination
branch
from
5ca7202
to
2e93e36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
When navigation to the invoices portal, the filterby resets when changing the page.
Current behavior before PR:
The filterby is reset to None and showing all invoices.
Desired behavior after PR is merged:
The invoices remains filtered by the filterby option.
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr