[IMP] website_slides: display comments of correct answers in submitted quiz #162180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
khpa-odoo
force-pushed
the
master-imp-elearning-add-comments-to-submitted-quiz-khpa
branch
2 times, most recently
from
8dad059
to
47a3233
Compare
ibo-odoo
reviewed
Apr 24, 2024
There was a problem hiding this comment.
@khpa-odoo Left few comments.
Note - Can achieve this using a JS file, but will likely encounter increased code complexity and some sort of code duplication. However, for now, will stick with the provided fix.
| @@ -27,10 +27,12 @@ | |||
| </label> | |||
| <span t-esc="answer.text_value"/> | |||
| </a> | |||
| <t t-if="widget.slide.completed and answer.is_correct" t-set="correct_answer_comment" t-value="answer.comment"/> | |||
There was a problem hiding this comment.
Need some specific name for t-set.
There was a problem hiding this comment.
@khpa-odoo My bad. correct_answer_comment would be better.
| </t> | ||
| <div class="o_wslides_quiz_answer_info list-group-item list-group-item-info d-none"> | ||
| <div t-attf-class="o_wslides_quiz_answer_info list-group-item list-group-item-info #{ correct_answer_comment ? '' : 'd-none'}"> |
| <i class="fa fa-info-circle"/> | ||
| <span class="o_wslides_quiz_answer_comment ms-2"/> | ||
| <span t-if="correct_answer_comment" t-esc="correct_answer_comment"/> |
There was a problem hiding this comment.
No need to add a new span here. And use t-out.
| @@ -527,10 +527,12 @@ | |||
| </label> | |||
| <span t-esc="answer['text_value']"/> | |||
| </a> | |||
| <t t-if="slide_completed and answer['is_correct']" t-set="correct_answer_comment" t-value="answer['comment']"/> | |||
khpa-odoo
force-pushed
the
master-imp-elearning-add-comments-to-submitted-quiz-khpa
branch
from
47a3233
to
ab63283
Compare
|
@ibo-odoo Applied the changes 👍 |
ibo-odoo
reviewed
Apr 25, 2024
| </t> | ||
| <div class="o_wslides_quiz_answer_info list-group-item list-group-item-info d-none"> | ||
| <div t-att-class="'o_wslides_quiz_answer_info list-group-item list-group-item-info %s' % ('' if comment_on_correct_answer else 'd-none')"> |
There was a problem hiding this comment.
May be better to use t-attf here.
khpa-odoo
force-pushed
the
master-imp-elearning-add-comments-to-submitted-quiz-khpa
branch
from
ab63283
to
5bdae2b
Compare
|
@ibo-odoo Applied the changes 👍 |
khpa-odoo
force-pushed
the
master-imp-elearning-add-comments-to-submitted-quiz-khpa
branch
from
5bdae2b
to
57e5d30
Compare
This commit enhances the user experience by making comments or explanations for correct answers of a quiz always accessible even after the quiz has been completed. This change is made in order to facilitate the users to review the comments later at anytime. Task-3847997
khpa-odoo
force-pushed
the
master-imp-elearning-add-comments-to-submitted-quiz-khpa
branch
from
57e5d30
to
41eb80a
Compare
khpa-odoo
changed the title
julien-banken
approved these changes
May 29, 2024
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jun 3, 2024
This commit enhances the user experience by making comments or explanations for correct answers of a quiz always accessible even after the quiz has been completed. This change is made in order to facilitate the users to review the comments later at anytime. Task-3847997 closes #162180 Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
meji-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jun 6, 2024
This commit enhances the user experience by making comments or explanations for correct answers of a quiz always accessible even after the quiz has been completed. This change is made in order to facilitate the users to review the comments later at anytime. Task-3847997 closes odoo#162180 Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the user experience by making comments or explanations for correct answers of a quiz
always accessible even after the quiz has been completed.
This change is made in order to facilitate the users to review the comments later at anytime.
Task-3847997