[FIX] l10n_ke_edi_tremol: discount sign #162193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jco-odoo
reviewed
Apr 17, 2024
| discount_sign = b'-' if discount_dict[line.id] > 0 else b'+' | ||
| discount = discount_sign + str(abs(discount_dict[line.id])).encode('cp1251')[:6] | ||
| discount_sign = b'-' if discount_dict[line.id] > 0 else b'' | ||
| discount = discount_sign + ('%.2f' % abs(discount_dict[line.id])).rstrip('0').rstrip('.').encode('cp1251')[:6] |
There was a problem hiding this comment.
Suggested change
| discount = discount_sign + ('%.2f' % abs(discount_dict[line.id])).rstrip('0').rstrip('.').encode('cp1251')[:6] | |
| discount = discount_sign + (str(abs(discount_dict[line.id]))).rstrip('0').rstrip('.').encode('cp1251')[:6] |
When sending an invoice with negative discount, the code responsible for serialising this discount applies a '+' plus sign to the discount. This is because the DiscAddP (Discount Addition Percentage) field on the device expects a negative amount for discounts (with a minus sign). However, due to errors with our own device, we have detected that surcharges (or negative discounts), serialised with a '+' plus sign actually trigger an error on the fiscal device (5 Input registers overflow). This commit adapts the serialisation to specify no sign in the case of negative discounts (surcharges), since a non-negative number in this field serves as a representation of a surcharge. Trailing zeros are stripped from the value and tests are updated to coincide with this change.
dbkosky
force-pushed
the
16.0-l10n-ke-edi-tremol-fix-discount-sign-dako
branch
from
eac340a
to
b87096a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending an invoice with negative discount, the code responsible for serialising this discount applies a '+' plus sign to the discount. This is because the DiscAddP (Discount Addition Percentage) field on the device expects a negative amount for discounts (with a minus sign).
However, due to errors with our own device, we have detected that surcharges (or negative discounts), serialised with a '+' plus sign actually trigger an error on the fiscal device (5 Input registers overflow).
This commit adapts the serialisation to specify no sign in the case of negative discounts (surcharges), since a non-negative number in this field serves as a representation of a surcharge. Trailing zeros are stripped from the value and tests are updated to coincide with this change.