17.0 l10n ke edi oscu dako #162196
17.0 l10n ke edi oscu dako #162196
Conversation
jco-odoo
force-pushed
the
17.0-l10n-ke-edi-oscu-dako
branch
from
a036f52
to
464a2f1
Compare
addons/l10n_ke_edi_oscu/__init__.py
Outdated
| _logger.info("Company %s already has the Kenyan localization installed, updating...", company.name) | ||
| ChartTemplate = env['account.chart.template'].with_company(company) | ||
| ChartTemplate._load_data({ | ||
| 'account.tax': ChartTemplate._get_ke_account_tax_etims_type(), |
There was a problem hiding this comment.
Couldn't it be made a little more straightforward by simply removing the _get_ke_account_tax_etims_type function, and running its code directly here ? It's just one line anyway, and the function is not called from other places.
There was a problem hiding this comment.
I believe the _get_ke_account_tax_etims_type function also serves the purpose of setting the l10n_ke_tax_type_id on taxes for new companies (or when reloading the CoA), thanks to its @template decorator.
addons/l10n_ke_edi_oscu/__init__.py
Outdated
|
|
||
| def _post_init_hook(env): | ||
| # UNSPSC category codes can be used in Kenya. | ||
| product_unspsc = env['product.unspsc.code'].search([('active', '=', False), ('code', '=ilike', '%00')]) |
There was a problem hiding this comment.
But doing it like that, we enable the codes for all other countries as well in the database. So, another company in a different country not needing them will get them as well. Isn't there a better way ? 🤔
There was a problem hiding this comment.
I don't think it would cause issues for companies in other countries. As far as I can see, the UNSPSC codes are just needed for some EDIs. I assume that if an EDI doesn't accept a Category Code for a product, this would simply result in some kind of error message for the user, who would then need to choose a different code.
| return super()._default_report_footer() | ||
|
|
||
| company_details = fields.Html(default=_default_company_details) | ||
| report_footer = fields.Html(default=_default_report_footer) |
There was a problem hiding this comment.
Not very robust if another module does the same kind of override
| **partner._l10n_ke_oscu_partner_content() # Partner details | ||
| } | ||
| company = partner.company_id or self.env.company | ||
| error, data, dummy = company._l10n_ke_call_etims('saveBhfCustomer', content) |
There was a problem hiding this comment.
Nothing done with the returned value because it's like registering the partner to the government, is that it ?
| class Users(models.Model): | ||
| _inherit = 'res.users' | ||
|
|
||
| l10n_ke_oscu_company_ids = fields.One2many('res.company', compute='_compute_l10n_ke_oscu_company_ids') |
There was a problem hiding this comment.
Is it really useful to make a computed field just for that ? It seems to be used only in the function below, and is anyway a mere filtering of another field.
There was a problem hiding this comment.
Indeed, need to how important it is to send for all branches.
| 'pwd': 'test', | ||
| 'useYn': 'Y', |
There was a problem hiding this comment.
| 'pwd': 'test', | |
| 'useYn': 'Y', | |
| 'pwd': 'test', | |
| 'useYn': 'Y', |
We usually write this kind of things like this. I'm not sure the style check will like your way ^^
| )) | ||
| ) | ||
|
|
||
| def action_l10n_ke_create_branch_user(self): # TODO - this is (again) just called with a button.. maybe it's better to do this automatically in the background |
There was a problem hiding this comment.
Not sure ; indeed we do that in a lot of places. And there is no way to know what has been submitted already, is there ?
antoine162
force-pushed
the
17.0-l10n-ke-edi-oscu-dako
branch
from
3a130d4
to
06e1691
Compare
antoine162
force-pushed
the
17.0-l10n-ke-edi-oscu-dako
branch
from
a61edfd
to
3d24999
Compare
jco-odoo
force-pushed
the
17.0-l10n-ke-edi-oscu-dako
branch
from
3d24999
to
6aecc81
Compare
- Disable Send to Fiscal Device button if l10n_ke_edi_oscu is installed - Only add TREMOL fields to invoice PDF if l10n_ke_cu_invoice_number set
antoine162
force-pushed
the
17.0-l10n-ke-edi-oscu-dako
branch
from
65c4b87
to
5be771b
Compare
🐳