[FIX] mrp: workorder state not updated on parent MO validation #162200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
It happens due to a loop `production reservation_state` -> `production state` -> `workorder state` -> `production reservation_state`
amoyaux
force-pushed
the
saas-16.3-reservation-state-wo-arm
branch
from
cb57aaf
to
99d5c1d
Compare
clesgow
reviewed
Apr 19, 2024
There was a problem hiding this comment.
I wonder if it wouldn't be better to only do what was planned in this forward-port #134711.
Quickly checked the use case (completing the Child MO and see if the Source MO has its own workorders updated) and it seemed to work properly, as it does in 16.0.
Feel free to correct me if I'm wrong, as I didn't dig too much in your fix! 😄
EDIT: Also, as it seems to be a recurring issue since 16.0, a test might be nice to have. 🙂
| @@ -2318,7 +2318,7 @@ def test_state_workorders(self): | |||
| mo.do_unreserve() | |||
|
|
|||
| self.assertEqual(list(mo.workorder_ids.mapped("state")), ["waiting", "pending"]) | |||
|
|
|||
| import pudb; pudb.set_trace() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It happens due to a loop
production reservation_state->production state->workorder state->production reservation_stateDescription of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr