[FIX] web_editor: click enter in a banner inside a list in chrome #162204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Clicking enter in a banner inside a list breaks the layout in chrome browser.
Steps to reproduce the issue:
Origin of the issue:
This is a browser issue, chrome in this specific case doesn't work properly, all the events until
textInput
are called when clickingenter
but the last event is never triggerged which is theinput
event. The specific case can be reproduced with this:Solution:
We manually trigger the
input
event in this specific case.Issue:
List inside a banner under a list doesn't align correctly
steps to reproduce the issue:
Origin of the issue:
Since the list inside the banner is considered nested list under the top
list, the
margin-bottom
is removed.Solution:
Reassign the style again when we are inside the banner.
task-3857296