[REF] mail: conquer the world (fourre-tout task, to be split) #162206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ease (future) test writing or improvements. Extracted from other commits working on tests. Task-3527752 (Mail: Post-PreMajor Freeze FixImpLint)
Add order on models, even technical ones, so that result of searching on those is always deterministic. Otherwise we might endup with random issues notably on runbot (query counters, asserts, ...). Task-3527752 (Mail: Post-PreMajor Freeze FixImpLint)
|
|
Cleanup mail module now that a lot of code changes were done recently and that
major version is slowly approaching.
Main changes
* improve docstrings: light rewording, add parameter types, remove outdated
comments, ...
* light guidelines / lint update: prepares future addition by extracting
cleaning, allowing to lessen future diff;
Task-3527752 (Mail: Post-PreMajor Freeze FixImpLint)
_message_create is already protected against unwanted parameters by _get_message_create_valid_field_names that gives a list of valid field names. There is therefore no need to redo a manual check in rating.
tde-banana-odoo
force-pushed
the
master-mail-cleanup-ref-tde
branch
from
3c82ee0
to
d670c8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.