[FIX] utm: set counters from 0 #162229
Open
[FIX] utm: set counters from 0 #162229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_find_or_create_record` works with the assumption that the new record will be created with the exact name requested. However `create` on most utm records ensures we never create duplicates by incrementing a counter at the end of the name `name, name [2], ...`. This counter simply increments from the highest existing value. Meaning if you have `name [2], name[4]` it will simply create `name [5]`. This breaks the assumption of `_find_or_create_record`. Meaning every single time this method is called with a name that is 'duplicate' but not an exact match, it will keep creating 'duplicates' that are not exact matches. This leads to a gigantic number of mediums and sources being created. task-3874538
thjo-odoo
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_find_or_create_recordworks with the assumption that the new record will be created with the exact name requested.However
createon most utm records ensures we never create duplicates by incrementing a counter at the end of the namename, name [2], ....This counter simply increments from the highest existing value. Meaning if you have
name [2], name[4]it will simply createname [5], even ifname(name [1]) doesn't exist.This breaks the assumption of
_find_or_create_record. Meaning every single time this method is called with a name that is 'duplicate' but not an exact match, it will keep creating 'duplicates' that are not exact matches.This leads to a gigantic number of mediums and sources being created.
task-3874538