[FIX] website_slides: translate course invite into recipients' language #162237

naja628 · 2024-04-17T13:56:07Z

Problem:
when adding attendees to a course, the sent email is not translated into the recipient's language.

Fix:
Upon sending, translate the email on a per recipient basis, but only when the final message to sent is exactly the same as the template. (i.e. the body was not edited from the dialog box)

This is a compromise to permit emails being translated while not breaking the following 2 current features:

there can be many recipients (with different languages)
the body is pre-filled with a template but can be edited further by the user directly from the dialog box.

opw-3862369

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

robodoo · 2024-04-17T13:56:34Z

Pull request status dashboard.

naja628 · 2024-04-17T13:57:20Z

Targeting saas-16.3, because it's the earliest supported versions where it "automatically" works, but the fix looks like it would be feasible as early as 15.0 if needed.

nle-odoo

looks good to me

nle-odoo · 2024-04-18T09:20:58Z

addons/website_slides/wizard/slide_channel_invite.py

-        subject = self._render_field('subject', slide_channel_partner.ids)[slide_channel_partner.id]
-        body = self._render_field('body', slide_channel_partner.ids)[slide_channel_partner.id]
+        set_lang, lang_opt = {}, {}
+        if (self.body_has_template_value):


unnecessary parenthesis

Suggested change

if (self.body_has_template_value):

if self.body_has_template_value:

also maybe it's not necessary to check, since _render_field as far as I can read will only use the template translation if the body/subject has not changed:

odoo/addons/mail/models/mail_composer_mixin.py

Lines 154 to 161 in 8919b75

if translation_asked and equality:

template = self.template_id.sudo() if call_sudo else self.template_id

return template._render_field(

template_field, *args, **kwargs,

)

record = self.sudo() if call_sudo else self

return super(MailComposerMixin, record)._render_field(field, *args, **kwargs)

and for the second part:

self.env['ir.qweb']._render(email_layout_xmlid, template_ctx, engine='ir.qweb', minimal_qcontext=True, raise_if_not_found=False, **lang_opt)

having it translated seems to make sense.

The body_has_template_value check is necessary because if the subject is unchanged, but the body is, the subject will still be translated (but not the body).

Actually, it probably breaks the other way around (changed subject, unchanged body). I assumed body_has_template_value would also check the subject but I guess not. I will check.

ah ok, makes sense then if we want in this case to have everything in same language

nle-odoo · 2024-04-18T09:32:07Z

addons/website_slides/wizard/slide_channel_invite.py

-        body = self._render_field('body', slide_channel_partner.ids)[slide_channel_partner.id]
+        set_lang, lang_opt = {}, {}
+        if (self.body_has_template_value):
+            lang = self._render_field('lang', slide_channel_partner.ids)[slide_channel_partner.id]


maybe we could use _render_lang instead, I guess this does the same:

Suggested change

lang = self._render_field('lang', slide_channel_partner.ids)[slide_channel_partner.id]

lang = self._render_lang(slide_channel_partner.ids)[slide_channel_partner.id]

Julien00859

This is a very nice feature, let's code a non-regression test and merge it :)

naja628 · 2024-05-06T14:43:52Z

The test is a bit janky, since we rely on _prepare_mail_values behaving a specific way, and since the way we get languages to work in a test environment is a bit weird, but I'm not sure how to make it better.

addons/website_slides/tests/test_slide_channel.py

tde-banana-odoo

Zboing, same some light, went to see if there were cookies, added some comments

addons/website_slides/tests/test_slide_channel.py

tde-banana-odoo · 2024-05-07T07:49:12Z

addons/website_slides/wizard/slide_channel_invite.py

-        body = self._render_field('body', slide_channel_partner.ids)[slide_channel_partner.id]
+        set_lang, lang_opt = {}, {}
+        subject_same_as_template = (self.template_id and self.subject == self.template_id.subject)
+        if self.body_has_template_value and subject_same_as_template:


Note that we could split (don't have to have both identical to check for translations, each one is separate)

Hello :)

Indeed we should check the returned result directly, here it is a bit indirect. Note that you can create a small template and its translation in the test, so that we don't rely on existing data.

I wanted to do something like this, but I'm not sure how I would achieve this.
As far as I can tell, the translations are stored in the db as jsonb, and the orm does not really provide a way to write to them, so we would have to do some raw SQL queries in the test? (I guess I'm missing something)

Note that we could split (don't have to have both identical to check for translations, each one is separate)

Do you mean that if (for example) the subject is unchanged but the body is, we still want the subject to be translated? I just assumed this was not what we wanted, but I guess it kinda makes sense/would simplify the code. (I think then we could completely remove the checks)

Side note: invite tests are inside 'test_attendee.py' test file (see notably 'test_invite_to_course'), so would add the test in that file to keep them in the same file :)

Will do :)

I wanted to do something like this, but I'm not sure how I would achieve this.

Just copy/paste the french text from the email. No code.

Or follow tde's advice to create a dedicated template inside the test, provide with the translation in the test and just assertEqual that

But then you rely on data ... and actual translation (you could have modified it in your db). Would say to create a small template and its translation so that the test is deterministic. To update it in new version, just update its body in a given environment should do the trick.

@tde-banana-odoo I wanted to r+ this one but I see that this question has been left open:

Note that we could split (don't have to have both identical to check for translations, each one is separate)

Do you mean that if (for example) the subject is unchanged but the body is, we still want the subject to be translated? I just assumed this was not what we wanted, but I guess it kinda makes sense/would simplify the code. (I think then we could completely remove the checks)

Yes, in the end what we want is to try to use translations if possible :)

@tde-banana-odoo Hello :)
I made the change

Julien00859

Thanks!

Problem: when adding attendees to a course, the sent email is not translated into the recipient's language. Fix: Upon sending, translate the email on a per recipient basis, but **only when** the final message to sent is exactly the same as the template. (i.e. the body was not edited from the dialog box) This is a compromise to permit emails being translated while not breaking the following 2 current features: * there can be many recipients (with different languages) * the body is pre-filled with a template but can be edited further by the user directly from the dialog box. opw-3862369

nle-odoo · 2024-05-14T08:48:26Z

robodoo delegate+

naja628 · 2024-05-14T08:49:46Z

@robodoo r+

Problem: when adding attendees to a course, the sent email is not translated into the recipient's language. Fix: Upon sending, translate the email on a per recipient basis, but **only when** the final message to sent is exactly the same as the template. (i.e. the body was not edited from the dialog box) This is a compromise to permit emails being translated while not breaking the following 2 current features: * there can be many recipients (with different languages) * the body is pre-filled with a template but can be edited further by the user directly from the dialog box. opw-3862369 closes #162237 Signed-off-by: Nathaniel Jacques (naja) <naja@odoo.com>

C3POdoo added the OE the report is linked to a support ticket (opw-...) label Apr 17, 2024

nle-odoo approved these changes Apr 18, 2024

View reviewed changes

naja628 force-pushed the saas-16.3-opw-3862369-elearning_invites_not_translated-naja branch from 09ca817 to 09cecbe Compare April 18, 2024 13:25

naja628 marked this pull request as ready for review April 18, 2024 15:03

C3POdoo requested a review from a team April 18, 2024 15:04

Julien00859 approved these changes May 6, 2024

View reviewed changes

naja628 force-pushed the saas-16.3-opw-3862369-elearning_invites_not_translated-naja branch 3 times, most recently from bf0329a to 838f6ad Compare May 6, 2024 14:28

naja628 force-pushed the saas-16.3-opw-3862369-elearning_invites_not_translated-naja branch from 838f6ad to 55e3444 Compare May 6, 2024 15:21

Julien00859 approved these changes May 6, 2024

View reviewed changes

addons/website_slides/tests/test_slide_channel.py Outdated Show resolved Hide resolved

tde-banana-odoo reviewed May 7, 2024

View reviewed changes

naja628 force-pushed the saas-16.3-opw-3862369-elearning_invites_not_translated-naja branch from 55e3444 to addee18 Compare May 8, 2024 08:54

naja628 requested a review from Julien00859 May 8, 2024 11:38

Julien00859 approved these changes May 8, 2024

View reviewed changes

Julien00859 requested a review from tde-banana-odoo May 8, 2024 12:37

naja628 force-pushed the saas-16.3-opw-3862369-elearning_invites_not_translated-naja branch from 150582c to 7b9a398 Compare May 13, 2024 09:20

tde-banana-odoo approved these changes May 14, 2024

View reviewed changes

robodoo temporarily deployed to merge May 14, 2024 11:56 Inactive

robodoo closed this May 14, 2024

This was referenced May 14, 2024

[FW][FIX] website_slides: translate course invite into recipients' language #165490

Closed

[FW][FIX] website_slides: translate course invite into recipients' language #165509

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FIX] website_slides: translate course invite into recipients' language #162237

[FIX] website_slides: translate course invite into recipients' language #162237

naja628 commented Apr 17, 2024

robodoo commented Apr 17, 2024

naja628 commented Apr 17, 2024

nle-odoo left a comment •

edited

nle-odoo Apr 18, 2024

naja628 Apr 18, 2024 •

edited

nle-odoo Apr 18, 2024

nle-odoo Apr 18, 2024

Julien00859 left a comment

naja628 commented May 6, 2024

tde-banana-odoo left a comment

tde-banana-odoo May 7, 2024

naja628 May 7, 2024 •

edited

Julien00859 May 7, 2024 •

edited

tde-banana-odoo May 7, 2024

Julien00859 May 13, 2024

tde-banana-odoo May 13, 2024

naja628 May 14, 2024

Julien00859 left a comment

nle-odoo commented May 14, 2024

naja628 commented May 14, 2024

	if (self.body_has_template_value):
	if self.body_has_template_value:

	if translation_asked and equality:
	template = self.template_id.sudo() if call_sudo else self.template_id
	return template._render_field(
	template_field, args, *kwargs,
	)

	record = self.sudo() if call_sudo else self
	return super(MailComposerMixin, record)._render_field(field, args, *kwargs)

	lang = self._render_field('lang', slide_channel_partner.ids)[slide_channel_partner.id]
	lang = self._render_lang(slide_channel_partner.ids)[slide_channel_partner.id]

[FIX] website_slides: translate course invite into recipients' language #162237

[FIX] website_slides: translate course invite into recipients' language #162237

Conversation

naja628 commented Apr 17, 2024

robodoo commented Apr 17, 2024

naja628 commented Apr 17, 2024

nle-odoo left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naja628 Apr 18, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Julien00859 left a comment

Choose a reason for hiding this comment

naja628 commented May 6, 2024

tde-banana-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

naja628 May 7, 2024 • edited

Choose a reason for hiding this comment

Julien00859 May 7, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Julien00859 left a comment

Choose a reason for hiding this comment

nle-odoo commented May 14, 2024

naja628 commented May 14, 2024

nle-odoo left a comment •

edited

naja628 Apr 18, 2024 •

edited

naja628 May 7, 2024 •

edited

Julien00859 May 7, 2024 •

edited