[FIX] web_editor: pillow version does not support #162256
Conversation
Issue: Please note that in Odoo 15, the requirement.txt files recommend that the Pillow minimum version be set to 7.0.0. Recently, there was a commit(odoo@e806328) made that changed the function textsize to textbbox. However, it's worth noting that textbbox is only compatible with Pillow version 8.0.0. Due to this incompatibility, the textbox function may not work properly in some images, whichcan cause the image to break. Solution: To resolve this issue, it's recommended that you revert back to the old code and keep the textsize function if the Pillow minimum version is set to 7.0.0.
|
Hello @d-fence Can you please review this PR an let me know if any further action is required from my side? |
|
Hello @Mtaylorr Can please check this PR and let me know if any further action is required from my end? |
Hello , thanks for the pr , I'm from bugfix so the decision is not up to me to decide if we want to revert the support for higher version of pillow , In the meantime, I was working on a pr to fix the issue here #163006, which more likely to be accepted since it fixes the issue directly without the need for a revert, |
Thank you for the feedback, one of our client is waiting to fix this and face this crop image issue in emails. |
Issue:
Please note that in Odoo 15, the requirement.txt files recommend that the Pillow minimum version
be set to 7.0.0. Recently, there was a commit made that changed the function textsize to textbbox. However, it's worth noting that textbbox is only compatible with Pillow version 8.0.0.
Due to this incompatibility, the textbox function may not work properly in some images, whichcan cause the image to break.
Solution:
To resolve this issue, it's recommended that you revert back to the old code and keep the textsize function if the Pillow minimum version is set to 7.0.0.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr