[FIX] website_sale: no automatic invoice when the full amount is discounted #162354
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dere-odoo
force-pushed
the
master-website_sale-fix-no-automatic-invoice-when-the-full-amount-is-discounted-dere
branch
3 times, most recently
from
1dc1c57
to
d609610
Compare
kcv-odoo
reviewed
Apr 26, 2024
| @@ -1768,6 +1768,7 @@ def shop_payment_validate(self, sale_order_id=None, **post): | |||
| order = request.env['sale.order'].sudo().browse(sale_order_id) | |||
| assert order.id == request.session.get('sale_last_order_id') | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Suggested change
Unnecessary change
| auto_invoice = str2bool( | ||
| request.env['ir.config_parameter'].sudo().get_param('sale.automatic_invoice') | ||
| ) | ||
| if auto_invoice: |
There was a problem hiding this comment.
I am not sure but this feels wrong 😕
I think what you need to do is change something in actual auto_invoice flow and take this into account but as you try to do it was creating payment entry and here we don't want to create payment entries 😐
Still need to dive in deeper 🦀
…ounted Prior to this commit: - When the "Automatic Invoice" setting was enabled and the total amount of the cart was zero due to a discount, no invoice was automatically created in the backend. This required manual intervention to create an invoice and confirm the sale order. Post this commit: - When the "Automatic Invoice" setting is activated and the total amount of the cart is zero thanks to a discount, the invoice is automatically created in the backend without the need for manual operation. Task: 3786812
dere-odoo
force-pushed
the
master-website_sale-fix-no-automatic-invoice-when-the-full-amount-is-discounted-dere
branch
from
d609610
to
978b0f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit:
Post this commit:
Task: 3786812
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr