[IMP] portal: add street2 to user details page #162355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khpa-odoo
force-pushed
the
master-imp-portal-add-street2-details-page-khpa
branch
from
65e2af5
to
799ebb3
Compare
|
Hey @khpa-odoo, LGTM 😃 Just a small change. You can update the description of the pr |
amdi-odoo
reviewed
Apr 24, 2024
| <select name="state_id" t-attf-class="form-select #{error.get('state_id') and 'is-invalid' or ''}"> | ||
| <option value="">select...</option> | ||
| <t t-foreach="states or []" t-as="state"> | ||
| <option t-att-value="state.id" style="display:none;" t-att-data-country_id="state.country_id.id" t-att-selected="state.id == int(state_id) if state_id else state.id == partner.state_id.id"> |
There was a problem hiding this comment.
Hello @khpa-odoo 😄
As we're updating those lines anyway, we could probably use the opportunity to change the ugly style="display:none;" to a d-none class ? 🙂
Thanks!
There was a problem hiding this comment.
Hello @amdi-odoo 😊
Sure! Updated the code 👍
There was a problem hiding this comment.
Hello again 😄
d-none isn't dynamic (no use of variables) so simply a class instead of the t-att-class should do it 😄
Thanks!
khpa-odoo
force-pushed
the
master-imp-portal-add-street2-details-page-khpa
branch
from
799ebb3
to
86078b0
Compare
This commit adds the field `Street 2` in the view of user details which is rendered by the route '/my/account' (My Account -> Addresses). It also reorganizes some fields in `portal_my_details_fields` to make them more organized. Additional: This commit replaces the style attribute used in `option` tag to set property `display: none`, with the bootstrap class `d-none`. Task-3875163
khpa-odoo
force-pushed
the
master-imp-portal-add-street2-details-page-khpa
branch
from
86078b0
to
49c6790
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 25, 2024
This commit adds the field `Street 2` in the view of user details which is rendered by the route '/my/account' (My Account -> Addresses). It also reorganizes some fields in `portal_my_details_fields` to make them more organized. Additional: This commit replaces the style attribute used in `option` tag to set property `display: none`, with the bootstrap class `d-none`. Task-3875163 closes #162355 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 25, 2024
This commit adds the field `Street 2` in the view of user details which is rendered by the route '/my/account' (My Account -> Addresses). It also reorganizes some fields in `portal_my_details_fields` to make them more organized. Additional: This commit replaces the style attribute used in `option` tag to set property `display: none`, with the bootstrap class `d-none`. Task-3875163 closes #162355 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 25, 2024
This commit adds the field `Street 2` in the view of user details which is rendered by the route '/my/account' (My Account -> Addresses). It also reorganizes some fields in `portal_my_details_fields` to make them more organized. Additional: This commit replaces the style attribute used in `option` tag to set property `display: none`, with the bootstrap class `d-none`. Task-3875163 closes #162355 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
zel-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 29, 2024
This commit adds the field `Street 2` in the view of user details which is rendered by the route '/my/account' (My Account -> Addresses). It also reorganizes some fields in `portal_my_details_fields` to make them more organized. Additional: This commit replaces the style attribute used in `option` tag to set property `display: none`, with the bootstrap class `d-none`. Task-3875163 closes odoo#162355 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the field
Street 2in the view of user details which is rendered by the route/my/account.(My Account -> Addresses)
It also reorganizes some fields in
portal_my_details_fieldsto make them more organized as in below structure:Additional:
This PR replaces the style attribute used in
optiontag to set propertydisplay: none, with the bootstrap classd-none.Task-3875163